sv-benchmarks icon indicating copy to clipboard operation
sv-benchmarks copied to clipboard

Files with known overflows outside of Bitvector category

Open PhilippWendler opened this issue 8 years ago • 6 comments

This year several tasks with unsigned overflows have been added to some categories, e.g., in #234.

In previous years, such tasks have been moved to the BitVectorsReach category and other categories have been kept mostly free of overflows.

Should this be done here as well? Otherwise, what is the reason for having a specific BitVectors category?

If we want to move the files, how do we organize them in the repository? Moving files between directories as has been done in the past is not good, because then the connection between readme, license, and source file is lost.

PhilippWendler avatar Nov 29 '16 08:11 PhilippWendler

I support moving such benchmarks into the BitVectorsReach category, as you suggested. I could be wrong, but I think you could leave those files in their original folders, but just update set files.

zvonimir avatar Nov 30 '16 03:11 zvonimir

Yes, not moving, but keeping the files close to their original and README and LICENSE.

Those files were added to a new .set file: https://github.com/sosy-lab/sv-benchmarks/blob/master/c/Overflows-Other.set

dbeyer avatar Dec 12 '16 09:12 dbeyer

@PhilippWendler, just to make sure I correctly understood: You mean signed overflow, right? ("This year several tasks with unsigned overflows")

dbeyer avatar Dec 12 '16 09:12 dbeyer

No, I meant unsigned overflows.

PhilippWendler avatar Dec 12 '16 15:12 PhilippWendler

@PhilippWendler: Please propose action item.

dbeyer avatar Dec 12 '16 15:12 dbeyer

Adding these files to another category is easy, but to remove them from the current category without removing them from the current directory is not so easy. How about creating a subdirectory for such files?

PhilippWendler avatar Dec 12 '16 19:12 PhilippWendler