benchexec icon indicating copy to clipboard operation
benchexec copied to clipboard

Upgrade to react-router 6

Open PhilippWendler opened this issue 3 years ago • 6 comments

We are using react-router 5 in our HTML table, and version 6 has been released. Upgrading needs some work on our side (guide).

We have to replace <Switch> with <Routes> and change a few things inside it, but this seems easy.

More complicated is that we use the useHistory hook to listen on history changes in ReactTable.js, and useHistory is gone now. We might be able to use useLocation or the history package that is used by react-router.

However, we also directly access the browser history in some other components and do window.history.pushState() and window.addEventListener("popstate", ...), and sometimes we also access the history property from react-router, which also seems to be gone. So this also needs changes and we should probably rewrite all this history handling to use the same kind of code based on react-router.

PhilippWendler avatar Jan 25 '22 08:01 PhilippWendler

When changing this we should also check whether this can be used to improve our filter handling, which currently relies on setImmediate (cf. 7ed146159a45d1a737d6b7865dd9122beb2662fe).

PhilippWendler avatar Jan 25 '22 09:01 PhilippWendler

I am a full-stack web developer I work with react. I want to work on this issue.

s2ahil avatar Feb 26 '24 22:02 s2ahil

That's great! Have a look at our readme for JS development, and if you have any questions, please ask. Questions that are specific to this issue can be asked here, for other questions please open a new issue or discussion.

PhilippWendler avatar Feb 27 '24 07:02 PhilippWendler

Im aiming for gsoc 2024 , so can I apply this issue for gsoc If I want to contribute in sosy-lab.

s2ahil avatar Mar 02 '24 07:03 s2ahil

Hi @PhilippWendler , I am Anuj, A full stack developer from India. I have understood the issue and would like to work on it

Anujvaid45 avatar Mar 08 '24 08:03 Anujvaid45

Hi, any help is welcome!

PhilippWendler avatar Mar 08 '24 08:03 PhilippWendler