Sebastian Stock

Results 124 comments of Sebastian Stock

> I mean, `5u"°" == 87.26646259971648 mm m^-1` is unphysical. Do you think `5u"mm/m" == 0.005` is unphysical as well? Or do you think that angles shouldn’t be dimensionless? >...

Thanks for your contribution! As indicated by the CI, you need to adapt the tests to the new behavior. It would also be good to add tests for printing with...

`UnitfulGauss` could also provide its own string macro (maybe `@cgs_str` instead of `@u_str`?) to avoid name conflicts.

> for `sigdigits` in particular, the objection that the rounding depends on your units does not apply, these agree: > > ```julia > tim_ns = tim |> u"ns" > round(ustrip(tim),...

> After declaring that you care about 3 digits, how surprising is it really that things don't agree beyond that? I would be surprised if `round(12345, sigdigits=3) != round(1.2345e4, sigdigits=3)`,...

Yes, floating-point numbers have finite precision and can introduce arbitrarily large errors. However, I don’t think we should give up unit-invariant arithmetic just because floating-point numbers can break it. >...

We could add `counts` and `ppm`. After all, we already have `percent`, `permille` and `pertenthousand`. The only issue I see with adding `counts` is that the following might seem inconsistent...

> Everything works except the last step because cells and IFU should not cancel out. Why is the last step necessary? If you want them to not cancel out, you...

I think the wording here is misleading: `round` does not “set precision of displayed value”. The `round` function does not display anything by itself, it returns a rounded value. Describing...

I think, the behavior for `Quantity{BigFloat}` should be fixed, since `isequal(x,y)` should always imply `hash(x) == hash(y)`. However, that means `hash(1u"m") == hash(100u"cm")` should also hold. The `Dates` stdlib already...