awesome-javascript icon indicating copy to clipboard operation
awesome-javascript copied to clipboard

Typo in TOC for Images

Open mycaule opened this issue 3 years ago • 11 comments

  • [x] Fix images link in Table of Contents.
  • [x] The TOC is actually pretty outdated, Regenerate TOC
  • [x] Delete one link, "SlidesJS is obsolete and no longer maintained", see nathansearles/slidesjs

mycaule avatar Jan 17 '22 15:01 mycaule

Feel free to update it accordingly. Making just a noun plural adds not much value if you think there're bigger changes needed in the table of content.

gokaygurcan avatar Jan 17 '22 15:01 gokaygurcan

Well the link didn't work before my change, so it is a simple but big improvement haha !

mycaule avatar Jan 17 '22 15:01 mycaule

Let's wait for the infamous validator, and merge it then. Cheers!

gokaygurcan avatar Jan 17 '22 16:01 gokaygurcan

Thanks I actually deleted the broken link validator found and regenerated the TOC completely using this online tool. https://luciopaiva.com/markdown-toc/

The TOC now looks ok, there were plenty of links missing under Utils.

mycaule avatar Jan 17 '22 16:01 mycaule

(up) this is ready

mycaule avatar Feb 07 '22 21:02 mycaule

It's nice work, don't get me wrong, but why we removed "utilities" and "ui" sections?

gokaygurcan avatar Feb 08 '22 05:02 gokaygurcan

Because it is not here anymore, I regenerated the summary based on what is on the document right now.

mycaule avatar Feb 08 '22 09:02 mycaule

I don't really think they ever existed. Both UI and Utilities were "logical groups" for some of the topics. I understand what "Notifications" mean there but also having a hard time to put it in a context. You see my point?

gokaygurcan avatar Feb 08 '22 20:02 gokaygurcan

Thanks, I have just indented UI and Utilities as groups as you recommended.

For the Utilities group it doesn't seem organized enough for me. It currently contains Files, Functional Programming, ... Machine Learning, ..., Benchmark.

It would also be clearer to use markdown section levels.

## Utilities
### Files
...
## UI
### Code highlighting
...

mycaule avatar Feb 09 '22 08:02 mycaule

it's ready tell me what you think

mycaule avatar Dec 29 '22 08:12 mycaule

这是来自QQ邮箱的假期自动回复邮件。   您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。

Ashe-reset avatar Dec 29 '22 08:12 Ashe-reset