phantom-render-stream icon indicating copy to clipboard operation
phantom-render-stream copied to clipboard

Very large timeout values cause immediate render failures.

Open markstos opened this issue 10 years ago • 2 comments

I happened to put in a huge timeout value to render as a way to express that it should never timeout, since I was debugging:

   timeout: 100000000000000000

Instead of getting the expected unlimited timeout, I got immediate failure. We should validate the timeout value before passing it on. Other invalid values cause immediate render failure as well:

timeout: "BOOM"

I'm not currently sure what the maximum allowed value for timeout is.

markstos avatar Jan 30 '15 16:01 markstos

Well maybe your number is just too damn big for the data type? Try Number.MAX_SAFE_INTEGER (which is 9007199254740991)

replete avatar Jun 19 '17 14:06 replete

Validating inputs is a best practice.

markstos avatar Jun 19 '17 15:06 markstos