stolon icon indicating copy to clipboard operation
stolon copied to clipboard

"wal_keep_size" value is not being honored on init

Open davissp14 opened this issue 3 years ago • 0 comments

What happened: wal_keep_size values lower than the minimum are not being honored on init.

What you expected to happen: I would expect users to be able to tune wal_keep_size to fit their use case. Extended WAL retention for replication slots are not always desirable, especially during situations where disk capacity is limited.

How to reproduce it (as minimally and precisely as possible): Initialize a new cluster with wal_keep_size set to zero and Stolon will use 128MB instead.

Anything else we need to know?: Looks like this was deliberate. @sgotti was there a specific reason for this? https://github.com/sorintlab/stolon/blob/master/cmd/keeper/cmd/keeper.go#L258-L259

Environment:

  • Stolon version: Latest

davissp14 avatar Feb 11 '22 15:02 davissp14