prezto icon indicating copy to clipboard operation
prezto copied to clipboard

Add IntelliJ to the list of exceptions

Open mpeterson opened this issue 3 years ago • 4 comments

Proposed Changes

Jetbrains IntelliJ adds an env variable __CFBundleIdentifier with the value com.jetbrains.intellij indicating that is the terminal triggered from here.

This patch adds this as an exception not to start tmux

mpeterson avatar Jun 01 '21 10:06 mpeterson

LGTM for macOS, does IntelliJ set the same variable on Windows and Linux?

indrajitr avatar Jun 01 '21 19:06 indrajitr

Instead of using the bundleIdentifier, we could use the $TERMINAL_EMULATOR variable. See #1958

tblaschke avatar Oct 02 '21 16:10 tblaschke

It might be better to use "$__CFBundleIdentifier" != com.jetbrains.*. This allows for all the tools under the jetbrains domain to load without starting tmux.

mahinshaw avatar Nov 17 '21 18:11 mahinshaw

Instead of using the bundleIdentifier, we could use the $TERMINAL_EMULATOR variable. See #1958

Come here to say that your solution works. Thank you! I'll add more details about my finding on your issue.

catflyflyfly avatar Sep 12 '22 02:09 catflyflyfly

Closing as https://github.com/sorin-ionescu/prezto/pull/1958 was merged which should address this.

There's some suggested improvements in the comments ☝️ , please feel free to open a PR implementing those as we're open to improvements.

jeffwidman avatar Oct 25 '22 20:10 jeffwidman