prezto icon indicating copy to clipboard operation
prezto copied to clipboard

A Docker Container, tool for prezto development

Open hlecuanda opened this issue 5 years ago • 4 comments

Proposed Changes

  • Provides a tool for rapid testing and development without disrupting your own einvironment
  • Most CI tools are based don docker containers so this could help get on the CI and QA bandwagon
  • I'm not exactly sure where to place this, and i'm sure is a lot of room for improvement. the Makefile and Dockerfile are heavily commented, plus i added a container-README.md that walks through the features already on the container if you wish to try it out

here's a quick screencast too https://asciinema.org/a/277054

hlecuanda avatar Oct 25 '19 20:10 hlecuanda

Sorry, I've been super busy - I really like the idea behind this, especially making some issues easier to reproduce. Thanks for taking the time to do this!

belak avatar Nov 07 '19 08:11 belak

My pleasure! and I'm sorry too, year end is coming up, and it's hectic around here this time of the year. I'm sure there is a lot of room for improvement for this container, and i'd be happy to work on any feedback to make it more useful for the prezto project.

Do you think this is the right place for this? or is this better suited for a separate branch, or an external contrubution? maybe a plugin? please let me know what ypu think

hlecuanda avatar Nov 12 '19 19:11 hlecuanda

Looks good after reading through the diff @hlecuanda , let me follow the README and make the container over the weekend. Does that sound good to you?

wadkar avatar Feb 13 '20 13:02 wadkar

So I played with thee Dockerfile over the weekend and it was fun. I think it'll help us develop/test prezto without messing with our day-to-day config changes.

I am more inclined towards following @casaper 's suggestion to mount the locally cloned prezto repository instead of using Makefiles to install it. I was on a limited bandwidth over the weekend, and my developer experience was severely hampered every time I needed to build the image with some modifications to the Dockerfile of my own.

wadkar avatar Feb 17 '20 11:02 wadkar