ssh: remove persistent socket; use macOS Keychain

[slarew]

Proposed Changes

• Remove persistent SSH auth socket.
• Make ps|grep more robust and POSIX compliant.
• On macOS, use -A switch to "add identities to the agent using any passphrase stored in the user's keychain."

[belak]

Looks like there's a conflict now. Would you mind fixing that?

[slarew]

I think I fixed the conflict.

[belak]

Does this still work on linux and does it connect to the same agent between different shell sessions? I'm not very familiar with this, unfortunately.

[slarew]

I've been running this on several Ubuntu 16.04 machines. Connects to same ssh-agent. Works in tmux.

On Aug 29, 2017, at 18:49, Kaleb Elwert [email protected] wrote:

Does this still work on linux and does it connect to the same agent between different shell sessions? I'm not very familiar with this, unfortunately.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[jeffwidman]

@indrajitr / @johnpneumann if either of you get a chance, can you take a look? I am in the same boat as @belak, that it looks good but I'm not very familiar with this and there's a number of changes in here.

Alternatively, the consequences of this breaking probably aren't the end of the world as it's unlikely to introduce a security risk, just a breakage risk so we'd hear about it immediately and fix it, so personally I'm fine with merging. Will give the other folks a day or two to weigh in though...

[johnpneumann]

I'll take a look tonight

[crivotz]

I tested the modification on Debian v9.1 - zsh 5.3.1 and found no problems (with and without ssh-askpass)