ascii-table icon indicating copy to clipboard operation
ascii-table copied to clipboard

Added support for multiline entries in tables

Open peblair opened this issue 8 years ago • 3 comments

This PR adds support for table rows with multiple lines of data (as mentioned in #20). Note that, given this, automatic line wrapping could easily be added with the use of a package such as wordwrap.

peblair avatar May 30 '16 17:05 peblair

@belph This is a very hard PR to consider, as there are many changes being made outside of the multiline feature. I am not opposed to adding this kind of functionality, but it must be isolated, and backwards compatible.

A specific example would be that you are proposing an API change along with this feature, in deprecating existing methods.

I am open to discussion on what changes should be made, but at the very least we should address them one at a time, in separate pull requests for each change.

sorensen avatar May 30 '16 23:05 sorensen

I understand your reservations. The goal of the changes were twofold:

  1. Support multiline table rows
  2. Allow aligning on vertical as well as horizontal axes

The reason for the deprecation stems from the fact that point (2) changes the semantics of what it means to "align" text (as in, should the text be aligned horizontally or vertically?).

I will take a look at breaking this apart into multiple PRs tomorrow; perhaps one for the simple multiline features and one for the API changes.

peblair avatar May 31 '16 01:05 peblair

definitely looking for multiline rows myself..

ORESoftware avatar Sep 05 '18 23:09 ORESoftware