Allan Odgaard

Results 46 comments of Allan Odgaard

List of double-width characters is from a Unicode publication: 45f847d01ec774ec4a621f553116b9a6b5dff865

Be aware that `CFStringGetCharacterAtIndex` return UTF-16 values (which could be part of a surrogate pair) because `CFStringRef` is backed by UTF-16. If you saw exceptions (as I see you added...

Thanks, I did understand the bug report, my comment was not related to that. Try ⌘R the following code and I think you will see what I mean: ``` cpp...

> font info can saved on file's extended attributes, just like current position, selected text etc I do not understand this part. We have to store selection etc. as extended...

Short version: Why don’t we want to force _double width_ for all CJK characters in the document?

Please squash the two commits (into one) and force-push, so that we get the changed indentation noise removed. I’ll look closer at this PR once I have wrapped up another...

I’m trying out this patch but on first test I notice these three issues: 1. Content is higher than frame: ![image](https://user-images.githubusercontent.com/11901/103294375-56c59700-4a24-11eb-99d2-aaae7ea57902.png) 2. Rendering issue when string contains newlines: ![image](https://user-images.githubusercontent.com/11901/103294661-dd7a7400-4a24-11eb-88ec-492d4d5b5fda.png) 3....

I think your proposal of adding syntax to the include rule is the best way to solve this issue. As for the actual syntax, I propose we treat `base` as...

For variables, there are two possibilities. 1. The macro-like approach which it sounds like you have in mind. Each grammar has a variable section at the top level which can...

Thanks, two comments: 1. I think the setting should not have a `disable`-prefix. The reason we use that prefix for the other settings is because we _disable_ standard behavior. For...