sora2-network icon indicating copy to clipboard operation
sora2-network copied to clipboard

[Bug]: [Add liquidity] Wrong error 'Unable to provide liquidity...'

Open ra9mls opened this issue 2 years ago • 0 comments

Preconditions

No response

Steps to reproduce

  1. Remove own liquidity from pool XOR-VAL, XSTUSD-VAL (2 examples)
  2. Add liquidity 0.0006 XOR-VAL
  3. Add liquidity 0.0006 XSTUSD-VAL

Actual behavior

User sees Error message in both cases: Unable to provide liquidity because its XOR part is lesser than the minimum value (0.007) https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fws.framenode-1.v1.tst.sora2.soramitsu.co.jp#/explorer/query/0x07d52867cacab8f13322f523a359c628e39be29a27b83b0e02edbe81c1eea35e

Expected behavior

  1. Unable to provide liquidity because its XOR part is less than the minimum value (0.0007)
  2. When user provide XSTUSD-VAL, he should see another text like:

Unable to provide liquidity because its XSTUSD part is less than the minimum value (0.0007)

Why we use 0.0007 minimum? Is it comes from old fees? May be need to update?

Environment

{"label"=>"Test"}

Operating System

No response

Additional context

If user add 0.0007 XOR-VAL - everything is OK

Please add Stefan Popov to review this fixes, can affect the frontend side.

ra9mls avatar Nov 03 '22 16:11 ra9mls