Sophia Mersmann

Results 43 comments of Sophia Mersmann

Hey @marcelgerber, thanks for the review! There was another bug here where a line chart turned into a discrete bar chart when you dragged the handles onto the same year...

* **#3570** 👈 * **#3569** * `master` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite

I just did a little digging into this, and as a matter of fact, we already choose to show labels for the bigger countries: https://github.com/owid/owid-grapher/blob/2f410aa4dac005de454d941f92c9ce1b7efdbd4c/packages/%40ourworldindata/grapher/src/stackedCharts/MarimekkoChart.tsx#L1279 However, we only consider labelling...

* **#3568** 👈 * `master` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite

* **#3570** * **#3569** 👈 * `master` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite

* **#3494** 👈 * **#3458** * `master` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite

* **#3527** 👈 * `master` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite

The accordion headers show up in the headings rotor for me (the whole button is wrapped in an h3). Don't they for you?

hey @ikesau, is this good to merge or should we make some more changes to the markup?