Karol Sobczak comments

Results 121 comments of


                                            Karol Sobczak

Wrap potentially conditional expressions with IF in PreAggregateCaseAggregations

thx!

Switch between distinct aggregation, mark distinct operator and OptimizeMixedDistinctAggregations automatically

Yup. This is what I meant

Switch between distinct aggregation, mark distinct operator and OptimizeMixedDistinctAggregations automatically

Might be related to https://github.com/trinodb/trino/issues/15106, cc @lukasz-stec

Switch between distinct aggregation, mark distinct operator and OptimizeMixedDistinctAggregations automatically

@lukasz-stec can we close it?

Serde improvments

> (DictionaryBlockEncoding) In the case of ORC or Parquet, the spec of the element constituting ids is Unsigned Integer. Will there be a problem if it is changed to short...

Use distinct aggregations by default (instead of MarkDistinctNode) for single distinct aggregation

@WinkerDu are you still working on this?

Use distinct aggregations by default (instead of MarkDistinctNode) for single distinct aggregation

Might be related to https://github.com/trinodb/trino/issues/15106 cc @lukasz-stec

Use distinct aggregations by default (instead of MarkDistinctNode) for single distinct aggregation

@lukasz-stec can we close it?

Improve performance for Equality Delete files in Iceberg connector

@jasonf20 IIUC this PR is caching deletion files. However, it seems that these can be cached per split rather than per query. In that case `ConnectorPageSourceProviderFactory` seems like too narrow...

Improve performance for Equality Delete files in Iceberg connector

@jasonf20 Would it make sense to cache deletion files across queries too?