Karol Sobczak
Karol Sobczak
Have you looked at: http://bgrins.github.io/videoconverter.js? It is a FFmpeg port targeted at converting video. Should be fairy easy to combine their FFmpeg configuration with the one for audioconverter.js.
@jerryleooo anything specific about this query? Do you have spill enabled?
I think the problem might be in `PreAggregateCaseAggregations#extractCaseAggregations` which doesn't check that aggregation type matches between all case aggregations. IIRC it only resolves that ``` if (!cumulativeFunction.getSignature().getReturnType().equals(aggregationType)) { // aggregation...
it could be that `io.trino.sql.planner.iterative.rule.PreAggregateCaseAggregations.PreAggregationKey` is missing some type information
BW: the query is correctly rewritten. It correctly fails with `Query 20240209_015013_00035_6x8dz failed: Cannot cast 'd' to INT`, because `d` indeed cannot be converted to int
> Yes, VARCHAR 'd' cannot be converted to INT, but the conversion shouldn't have been attempted in the first place: @martint what does spec says about it? I would guess...
@weiatwork would you like to work on a fix? For expressions that can fail we need to wrap them in expression similar to `if(c1 = 1, cast(c2 as int), null)`
@weiatwork there is also division by zero etc. ``` agg(CAST(case when c1 = 1 then c2 end AS INT)) agg(case when c1 = 1 then CAST(c2 as int) end) ```...
> @sopel39 Do you have any other concerns regarding the fix? No. I think it should do the job
looks much easier, small nits