sopel
sopel copied to clipboard
version: retrieve commit hash for git worktrees
Description
Tin and personal wish fulfillment. With this changeset, the version
command will report commit information if Sopel is running from a git-worktree
.
The current revision of the version
plugin only supports reading commit information when the host Sopel is running inside of a 'real' git repository. I find it convenient to run Sopel from a worktree for a "near to development" copy, and it's nice to still have the commit information in this use-case.
Checklist
- [x] I have read CONTRIBUTING.md
- [x] I can and do license this contribution under the EFLv2
- [ ] No issues are reported by
make qa
(runsmake lint
andmake test
)- I did see some errors when running
mypy
becausetypes-urllib3
was not installed. I'm not sure if that's missing fromdev-requirements.txt
or if my local environment was in a weird state. - Also saw some test failures in
test_example_suggest_*
caused by content decoding errors. I only vaguely recognize the issue, but I'm confident it's not this changeset's fault.
- I did see some errors when running
- [x] I have tested the functionality of the things this change touches
- I did see some errors when running
mypy
becausetypes-urllib3
was not installed. I'm not sure if that's missing fromdev-requirements.txt
or if my local environment was in a weird state.
Well it's not in dev-requirements.txt
, and CI doesn't appear to install it from anywhere, but in CI its absence doesn't cause any make lint
errors. Curious. Locally, pipdeptree
doesn't even identify any packages as depending on types-urllib3
either, yet it's present in my environment. Let's chase this one down if it happens to anyone else.
- Also saw some test failures in
test_example_suggest_*
caused by content decoding errors. I only vaguely recognize the issue, but I'm confident it's not this changeset's fault.
It's the same issue I described in a couple of my PRs, and is probably because you haven't reinstalled/--upgrade
d the dev-requirements.txt
since #2519 (if I had to guess).
To me, this change is low-stakes and could be shipped in 8.0.0 while I still lack the time (😩) to work on release notes. (It's just nuts how much stuff has kept coming up for me this month! I thought I had everything planned out for $work etc. but noooo.)
It's the same issue I described in a couple of my PRs, and is probably because you haven't reinstalled/
--upgrade
d thedev-requirements.txt
since #2519 (if I had to guess).
Huh, I had an old urllib3
. Might be why I saw types-urllib3
weirdness too. I could have sworn I installed the requirements file, but I guess I only manually installed the stubs. Maybe I left my environment in a bad state while checking something against 7.1.9.
To me, this change is low-stakes and could be shipped in 8.0.0 while I still lack the time (😩) to work on release notes. (It's just nuts how much stuff has kept coming up for me this month! I thought I had everything planned out for $work etc. but noooo.)
Maybe, but let's defer it anyway IMO.