soot icon indicating copy to clipboard operation
soot copied to clipboard

A possible mistake regarding soot.Scene#getPhantomRefs

Open Wangxiz opened this issue 1 year ago • 0 comments

Hi, I have recently read some of the code for soot.Scene and I have found a possible inconsistency/mistake in the code. In soot.Scene we have defined an allowsPhantomRefs field and a set method to set it (setPhantomRefs), which is fine. But instead of taking the value from this field, our get method returns Options.v().allow_phantom_refs() directly. The inconsistency here may cause some problems and also means that the value set via the set method does not have any effect. Furthermore, as far as I can see, this set method is used in at least 15 places in the code, and I am currently unsure if these uses are causing problems.

Wangxiz avatar Jul 03 '23 12:07 Wangxiz