Spark Framework

[kadirayk]

[linghuiluo]

@kadirayk what is the plan for this PR? Are you going to comment the classes which I should take a look?

[kadirayk]

@linghuiluo there is a bug after merging, that fails some tests. I wanted to fix that first.

[linghuiluo]

@linghuiluo there is a bug after merging, that fails some tests. I wanted to fix that first.

No problem, take your time

[kadirayk]

@linghuiluo added some comments now, maybe you can have a look at these classes in the meantime. Thanks :)

[linghuiluo]

@kadirayk I didn't see any handling of implicit edges such as Thread.run() -> Thread.start() or Executor.execute() to Thread.run(). or AsyncTask.execute() -> AsyncTask.doInBackground() Probably you just considered the basic edges at first, but don't forget to consider those edges in future. https://github.com/soot-oss/soot/blob/492fb4713f7e124ffdb0c991ac5453f96c23cc29/src/main/resources/virtualedges.xml https://github.com/soot-oss/soot/blob/3966f565db6dc2882c3538ffc39e44f4c14b5bcf/src/main/java/soot/jimple/toolkits/callgraph/OnFlyCallGraphBuilder.java#L853

[kadirayk]

@linghuiluo thank you, just created an issue for that.

[github-actions[bot]]

Test Coverage Total coverage 0.6463063969156577 Amount of covered (bytecode-)branches 0.53099173553719

[struce2]

May I ask if spark is already available?

[Jclavo]

@kadirayk may I ask what the status of this PR is? cc: @linghuiluo @swissiety