nmos-cpp icon indicating copy to clipboard operation
nmos-cpp copied to clipboard

Published 20 hours ago • verified publisher icon sony

Fix downgrade support

Open lo-simon opened this issue 1 year ago • 2 comments

Fix IS-04 (v1.3) downgrade resource to register to v1.2 Registry.

There are some parameters which have been extended in nmos-parameter-registers for the latest nmos version.

The problem was identified when a downgraded v1.3 video flow with transfer_characteristic set to UNSPECIFIED failed to register to the v1.2 Registry. It is because v1.2 video flow schema used in the Registry does not allow transfer_characteristic to be UNSPECIFIED. This PR sets the default values for the downgraded resources when an invalid value is used or removes it if the parameter is optional.

See https://specs.amwa.tv/nmos-parameter-registers/branches/main/flow-attributes/#transfer-characteristic

lo-simon avatar Sep 07 '23 10:09 lo-simon

Since this is a significant change to code which is used by both Node and Registry, I recommend unit tests with very good coverage are added.

garethsb avatar Sep 07 '23 10:09 garethsb

Since this is a significant change to code which is used by both Node and Registry, I recommend unit tests with very good coverage are added.

Yes totally agree

lo-simon avatar Sep 08 '23 09:09 lo-simon