nmos-cpp icon indicating copy to clipboard operation
nmos-cpp copied to clipboard

Default Domain looks at all interfaces even though just one is desired

Open jwpwh opened this issue 4 years ago • 2 comments

I was getting errors similar to #101. Specifying "local" in the settings gets around the error message.

My question is with regards to nmos::details::default_domain() called from nmos::get_domain() which gets a domain name if one is not specified in the settings.

In my settings, I have "host_address" and "host_addresses" set so that only one interface is listed. The get_domain() calls default_domain() which checks all interfaces on my windows system.

Shouldn't the default_domain() or get_domain() functions be limited to looking at just the interfaces listed in "host_addresses" in the settings?

jwpwh avatar Apr 27 '20 14:04 jwpwh

Yes, that sounds reasonable.

garethsb avatar Apr 27 '20 19:04 garethsb

FWIW, I don't yet have a way of getting per-interface domain on *nix platforms, which means even filtering the host_interfaces by their addresses against the host_addresses isn't going to help there.

https://github.com/sony/nmos-cpp/blob/f115a216252313482ee8392def06e5cafc09fe07/Development/cpprest/host_utils.cpp#L193-L194

garethsb avatar Apr 28 '20 08:04 garethsb