flutter-embedded-linux icon indicating copy to clipboard operation
flutter-embedded-linux copied to clipboard

Published 20 hours ago • verified publisher icon sony

Building flutter-engine with fontconfig support

Open andreadaoud opened this issue 3 years ago • 1 comments

If we want to display CJK characters using system font, we have to enable fontconfig support. Just add --enable-fontconfig to ./flutter/tools/gn command. Could you please consider enabling this in your CI pipeline when you build the artifacts?

andreadaoud avatar Sep 08 '22 15:09 andreadaoud

Hi @taka-okayama

This request is understandable/reasonable to me.

Just add --enable-fontconfig to ./flutter/tools/gn command. Could you please consider enabling this in your CI pipeline when you build the artifacts?

Can you please address that? All you have to do is only adding --enable-fontconfig to the build script in the CI.

Updated to add --enable-fontconfig: https://github.com/sony/flutter-embedded-linux/wiki/Building-Flutter-Engine-from-source#4-build-embedder

HidenoriMatsubayashi avatar Sep 10 '22 01:09 HidenoriMatsubayashi

@taka-okayama ping

HidenoriMatsubayashi avatar Oct 06 '22 02:10 HidenoriMatsubayashi

@HidenoriMatsubayashi sorry, we have a problem in CI now.

taka-okayama avatar Oct 06 '22 09:10 taka-okayama

@taka-okayama Ok, then please change the recipe after the CI is green.

HidenoriMatsubayashi avatar Oct 06 '22 12:10 HidenoriMatsubayashi

https://github.com/flutter/flutter/issues/112919

taka-okayama avatar Oct 07 '22 00:10 taka-okayama

Thanks. Commented.

HidenoriMatsubayashi avatar Oct 07 '22 01:10 HidenoriMatsubayashi

@taka-okayama The issue was fixed. Please address this issue.

HidenoriMatsubayashi avatar Oct 12 '22 05:10 HidenoriMatsubayashi

@andreadaoud @HidenoriMatsubayashi

I've updated artifacts with --enable-fontconfig. Could you confirm?

taka-okayama avatar Oct 13 '22 01:10 taka-okayama

@taka-okayama

You mean you updated https://github.com/sony/flutter-embedded-linux/releases/tag/c08d7d5efc and its build includes that option? Or you just changed only the internal recipe?

HidenoriMatsubayashi avatar Oct 13 '22 03:10 HidenoriMatsubayashi

@HidenoriMatsubayashi

oh, sorry. Local CI completed but deployment step in CI was skipped because of no change in flutter version. I'm changing CI script to re-build artifacts forcibly(option).

taka-okayama avatar Oct 13 '22 07:10 taka-okayama

Understood, but it's OK for me to wait until next release.

HidenoriMatsubayashi avatar Oct 13 '22 08:10 HidenoriMatsubayashi

I've already compiled myself, so waiting until next release is also okay for me. But I'm willing to test anytime.

andreadaoud avatar Oct 13 '22 09:10 andreadaoud

@HidenoriMatsubayashi @andreadaoud

thanks for your patience. this change will be deployed next release.

taka-okayama avatar Oct 14 '22 08:10 taka-okayama

@taka-okayama Confirmed that this option was included in the artifacts for v3.3.5. Thanks. I'll close the issue.

HidenoriMatsubayashi avatar Oct 21 '22 12:10 HidenoriMatsubayashi