Binance icon indicating copy to clipboard operation
Binance copied to clipboard

Possible abstraction to include more exchanges

Open LadislavBohm opened this issue 6 years ago • 6 comments

Hello, when looking at this library and how great it already is (really good job!), I'm thinking about possible abstractions that would allow creating client libraries for more exchanges based on principles from this one. I imagine creating something like an abstract nuget package that would contain all base code to create http/socket clients. It would handle rate limiting, fees, authentication, socket reconnection etc. Creating exchange-specific client would then require defining some basic stuff like url's, model classes etc. Do you think it is possible with the current state of this library? Or whether it is worth the amount of work (I would definitely help) required. Thanks

LadislavBohm avatar Mar 26 '18 12:03 LadislavBohm

@LadislavBohm, thanks.

I think that is something for the future. It is something I have envisioned from the beginning, but first I wanted to see what works best with Binance before abstracting.

sonvister avatar Mar 27 '18 18:03 sonvister

I understand (just wanted to make this clear in the answer here), if this is planned for the future and there is still some more work in Binance implementation, you might want to close this issue and reopen it when the time comes.

LadislavBohm avatar Apr 19 '18 14:04 LadislavBohm

A bitmex version would be nice

evo11x avatar Nov 18 '18 12:11 evo11x

Bitmex or Bitfinex. Where you can short on bear market..

alikalfaoglu avatar Mar 07 '19 17:03 alikalfaoglu

@LadislavBohm, thanks.

I think that is something for the future. It is something I have envisioned from the beginning, but first I wanted to see what works best with Binance before abstracting.

By the way, I developed a bot, which is in beta, fully functional working and as far as I can see, there is not much to say for your lib. Working perfectly. Thanks.

alikalfaoglu avatar Mar 07 '19 17:03 alikalfaoglu

Binance will be supporting margin trading soon I guess, therefore no need for this in that case. At least, not needed for me..

alikalfaoglu avatar Mar 21 '19 18:03 alikalfaoglu