pyramid_celery icon indicating copy to clipboard operation
pyramid_celery copied to clipboard

Published 20 hours ago • verified publisher icon sontek

Support custom celeryconfig modules

Open phrfpeixoto opened this issue 4 years ago • 5 comments

I wanted to use this but had a custom celery config module, so I made this change to support it.

phrfpeixoto avatar Feb 28 '21 20:02 phrfpeixoto

Coverage Status

Coverage remained the same at 95.031% when pulling 9f93d2c4b947f086f0be029a06cc4c7abf172cd7 on phrfpeixoto:custom_celeryconfig into cf8aa80980e42f7235ad361874d3c35e19963b60 on sontek:master.

coveralls avatar Feb 28 '21 20:02 coveralls

@phrfpeixoto Could you implement this a little differently:

  • Keep use_celeryconfig as a boolean.
  • Introduce a new field celery_config_module (or a better name if you have one) and load it from there if set

So use_celeryconfig = true + celery_config_module = app.celeryconfig would do what you want, otherwise without a module said it would use the default behavior

sontek avatar Feb 28 '21 23:02 sontek

Will do.

phrfpeixoto avatar Feb 28 '21 23:02 phrfpeixoto

@sontek Done.

phrfpeixoto avatar Mar 04 '21 12:03 phrfpeixoto

Is this still relevant?

phrfpeixoto avatar Apr 05 '22 11:04 phrfpeixoto