onehalf
onehalf copied to clipboard
Question: Requirements for a port to lua
As there are now fairly complete status lines and packers: Would you consider a port to lua? What expectations would you have before porting to lua?
As I checked, you have only differenence in color definitions and the following lines between onehalfdark
and onehalflight
:
call s:h("Pmenu", s:fg, s:cursor_line, "")
call s:h("PmenuSel", s:bg, s:blue, "")
call s:h("PmenuSbar", "", s:cursor_line, "")
call s:h("PmenuThumb", "", s:comment_fg, "")
...
call s:h("Include", s:purple, "", "")
Meta: Is the last difference of purple intentional?
Ahh good catch! Thanks! It's not intentional. I should fix that. AFAIK the Include
highlight group is for the #include
preprocessing directive. I consider that a keyword so the blue will need to be updated to purple.
To answer your first question: I'm sure porting to lua isn't difficult as the theme barely contains any logic. However, if it ain't break, don't fix it. Also I no longer use Vim as my main text editor, so this is definitely not high on my list. If you (or anyone else) is willing to port it, I'll be more than happy to approve the change :beers: