sonobus icon indicating copy to clipboard operation
sonobus copied to clipboard

Recording "each connected user" gets names wrong sometime

Open strk opened this issue 4 years ago • 2 comments

I've been recording each connected user but the filenames on disk did not match the usernames. I think this happened when new users came in or got disconnected and reconnected. This happened as of Sonobus built from sources as of 513d52145297ba73adde902f92455cc108b89eca

strk avatar Feb 11 '21 19:02 strk

Oh yeah, this will happen! The files are created only when you hit record.... but the real problem is that the audio content that goes into the files is based on the index of the connected user, so if someone drops out it will get shifted and the wrong people after that will get written to the existing files. I will fix at least that part... dealing with new users coming in I'm going to ignore, if you have an active recording and someone else joins it will not create a recording for them because it wouldn't be in sync with the others.

The feature as designed was assuming that you would be in a controlled private session during recording. Your mix recording should be fine, of course... a good reason to always write that too as a backup.

essej avatar Feb 11 '21 19:02 essej

Thanks a lot, sonobus is great !

strk avatar Feb 11 '21 19:02 strk