Tangram icon indicating copy to clipboard operation
Tangram copied to clipboard

Published 20 hours ago • verified publisher icon sonnyp

Bug: missing favicons

Open erlefloch opened this issue 2 years ago • 12 comments

It would be great to be able to choose the tab icon manually. This would be useful for example for Slack, which doesn't display any icon near the tab title: image

erlefloch avatar Feb 16 '23 20:02 erlefloch

Cool, I've been missing that too. I'm gonna try to do it. Never contributed to a github repo ever. It'll be my first one

victorodg avatar Mar 09 '23 19:03 victorodg

I don't want custom tab icons for now.

Let's solve the problem of Tangram not picking up Slack favicon instead.

sonnyp avatar Mar 09 '23 19:03 sonnyp

To clarify: tabs are taking too much space, I might remove them soon in favor of https://floss.social/@sonny/109672793649336496

until then it's best not to look into this

sonnyp avatar Mar 09 '23 20:03 sonnyp

Oh but I really like the spacing for the tabs :( could we make it customizable?

victorodg avatar Mar 09 '23 20:03 victorodg

Why not :+1:

sonnyp avatar Mar 09 '23 20:03 sonnyp

Here I have GitHub not displaying the icon too. Kinda bugs me. Could I do something about it?

victorodg avatar Mar 09 '23 20:03 victorodg

You'll have to find out where it's failing - it's probably a small thing since it works fine in Epiphany / GNOME Web https://github.com/sonnyp/Tangram/blob/f06d83a89520f6aed8bf4fc7a0ed81de6108d254/src/tab.js#L27

sonnyp avatar Mar 09 '23 20:03 sonnyp

You'll have to find out where it's failing - it's probably a small thing since it works fine in Epiphany / GNOME Web

https://github.com/sonnyp/Tangram/blob/f06d83a89520f6aed8bf4fc7a0ed81de6108d254/src/tab.js#L27

Cool, I'll try

victorodg avatar Mar 09 '23 20:03 victorodg

@sonnyp & @victorodg thank you very much ! I've updated the title of the issue to match the discussion.

erlefloch avatar Mar 09 '23 20:03 erlefloch

Epiphany / GNOME web on browser tab:

  • github favicon ✗
  • slack favicon ✓

Epiphany / GNOME web on PWA:

  • github favicon ✓
  • slack favicon ✗

image image image

🙃

erlefloch avatar Mar 09 '23 21:03 erlefloch

you have to use GNOME Web 44, not 43

sonnyp avatar Mar 09 '23 21:03 sonnyp

Thanks for the hint. Using Epiphany Technology Preview (flatpak, version 44~rc) :

browser tab:

  • github favicon still ✗
  • slack favicon still ✓

PWA:

  • PWA installation did not work on Epiphany Technology Preview (tried a few times).

EDIT: tried again with Epiphany v45. The Slack favicon is now correctly displayed both on browser tab and webapp, whereas the GitHub favicon fails both.

erlefloch avatar Mar 09 '23 21:03 erlefloch