sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

[FC] remove FC delay field

Open stepanblyschak opened this issue 1 year ago • 4 comments

What I did

Simplify approach to delaying counters on warm boot and fast boot. Removed FLEX_COUNTER_DELAY_STATUS_FIELD and instead postpone all FC processing to happen after apply view to not delay data plane configuration.

The CONFIG_DB should not be updated in runtime anymore for counters to be delayed.

How I did it

Removed FLEX_COUNTER_DELAY_STATUS_FIELD and corresponding counterpoll commands (that weren't supposed to be used by user directly anyway). Updated db_migrator.py to remove that field.

How to verify it

Ran fast-reboot from 202405. Made sure no delay field present, counters are enabled and delayed.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

stepanblyschak avatar Oct 15 '24 10:10 stepanblyschak

/azpw run

stepanblyschak avatar Oct 22 '24 09:10 stepanblyschak

/AzurePipelines run

mssonicbld avatar Oct 22 '24 09:10 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 22 '24 09:10 azure-pipelines[bot]

@qiluo-msft @wen587 Please help review

bingwang-ms avatar Nov 01 '24 17:11 bingwang-ms

@vaibhavhd Could you review fastreboot, and db_migrator parts?

qiluo-msft avatar Dec 02 '24 06:12 qiluo-msft

==============================================================================
##[error]Not found workingDirectory: /__w/1/target/debs/bullseye/
Finishing: Install Debian dependencies

Will restart

stepanblyschak avatar Dec 04 '24 09:12 stepanblyschak

/azpw run

stepanblyschak avatar Dec 04 '24 09:12 stepanblyschak

/AzurePipelines run

mssonicbld avatar Dec 04 '24 09:12 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 04 '24 09:12 azure-pipelines[bot]

/azp run Azure.sonic-utilities

bingwang-ms avatar Dec 09 '24 22:12 bingwang-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 09 '24 22:12 azure-pipelines[bot]

@stepanblyschak Can you please sync code with master branch? The PR test has been fixed in master branch.

bingwang-ms avatar Dec 09 '24 22:12 bingwang-ms

@shlomibitton can you review this PR?

vaibhavhd avatar Dec 23 '24 22:12 vaibhavhd

/azp run

mssonicbld avatar Jan 02 '25 14:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 02 '25 14:01 azure-pipelines[bot]

/azp run

mssonicbld avatar Jan 02 '25 14:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 02 '25 14:01 azure-pipelines[bot]

/azp run

mssonicbld avatar Jan 03 '25 09:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 03 '25 09:01 azure-pipelines[bot]

@vaibhavhd kindly reminder to have this reviewed and merged

liat-grozovik avatar Feb 02 '25 08:02 liat-grozovik

@qiluo-msft , @wen587 Can you help review again?

bingwang-ms avatar Feb 05 '25 19:02 bingwang-ms