sonic-utilities
sonic-utilities copied to clipboard
[FC] remove FC delay field
What I did
Simplify approach to delaying counters on warm boot and fast boot. Removed FLEX_COUNTER_DELAY_STATUS_FIELD and instead postpone all FC processing to happen after apply view to not delay data plane configuration.
The CONFIG_DB should not be updated in runtime anymore for counters to be delayed.
How I did it
Removed FLEX_COUNTER_DELAY_STATUS_FIELD and corresponding counterpoll commands (that weren't supposed to be used by user directly anyway). Updated db_migrator.py to remove that field.
How to verify it
Ran fast-reboot from 202405. Made sure no delay field present, counters are enabled and delayed.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
/azpw run
/AzurePipelines run
Azure Pipelines successfully started running 1 pipeline(s).
@qiluo-msft @wen587 Please help review
@vaibhavhd Could you review fastreboot, and db_migrator parts?
==============================================================================
##[error]Not found workingDirectory: /__w/1/target/debs/bullseye/
Finishing: Install Debian dependencies
Will restart
/azpw run
/AzurePipelines run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run Azure.sonic-utilities
Azure Pipelines successfully started running 1 pipeline(s).
@stepanblyschak Can you please sync code with master branch? The PR test has been fixed in master branch.
@shlomibitton can you review this PR?
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@vaibhavhd kindly reminder to have this reviewed and merged
@qiluo-msft , @wen587 Can you help review again?