sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

IP Assignment Issue

Open ridahanif96 opened this issue 1 year ago • 7 comments

What I did

Added Check for IP Assignment on Port when a Vlan is configured. This PR is created in response to Issue

How I did it

Modified config/main.py to add check for IP Assignment when Port has vlan membership

How to verify it

After this, ip cannot be assigned on port which is configured to a VLAN.

ridahanif96 avatar Jul 09 '24 10:07 ridahanif96

@dgsudharsan can you help review this PR

ridahanif96 avatar Jul 09 '24 12:07 ridahanif96

@bingwang-ms @qiluo-msft Can you please help to review and merge this fix?

dgsudharsan avatar Jul 10 '24 04:07 dgsudharsan

@ridahanif96 Please create a separate PR for 202311

dgsudharsan avatar Jul 10 '24 08:07 dgsudharsan

@ridahanif96 Please create a separate PR for 202311

@dgsudharsan 202311 branch doesn't have these changes. Supported change is added in 202405. Should i make PR for 202405?

ridahanif96 avatar Jul 11 '24 05:07 ridahanif96

@ridahanif96 Please create a separate PR for 202311

@dgsudharsan 202311 branch doesn't have these changes. Supported change is added in 202405. Should i make PR for 202405?

I see. I removed request for 202311. No need separate PR for 202405 as there is a "Request for 202405" tag

dgsudharsan avatar Jul 11 '24 05:07 dgsudharsan

@ridahanif96 Please create a separate PR for 202311

@dgsudharsan 202311 branch doesn't have these changes. Supported change is added in 202405. Should i make PR for 202405?

I see. I removed request for 202311. No need separate PR for 202405 as there is a "Request for 202405" tag

Okay

ridahanif96 avatar Jul 11 '24 05:07 ridahanif96

@qiluo-msft @bingwang-ms can you pls help review and merge this. Thanks in advance

ridahanif96 avatar Jul 11 '24 05:07 ridahanif96

@qiluo-msft @bingwang-ms can you pls help review & merge this.

ridahanif96 avatar Jul 23 '24 04:07 ridahanif96

@bingwang-ms Can you please cherry-pick for 202405?

dgsudharsan avatar Jul 24 '24 15:07 dgsudharsan

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-utilities/pull/3445

mssonicbld avatar Jul 24 '24 18:07 mssonicbld