sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

Utilities Changes for DHCP DoS Mitigation Feature

Open asraza07 opened this issue 1 year ago • 15 comments

What I did

Added config interface dhcp-mitigation-rate add/del and show interfaces dhcp-mitigation-rate commands for DHCP mitigation rate attribute in config_db and added support for new attribute in DB Migrator

How I did it

Add/del commands add/remove interface DHCP rate limits defined by the user to PORT_TABLE in config_db and show command reads and displays DHCP rate limits on interfaces in the form of a table

asraza07 avatar May 02 '24 10:05 asraza07

@Yarden-Z @yaqiangz @Blueve Can you pls help review this PR!

ridahanif96 avatar May 20 '24 15:05 ridahanif96

@Yarden-Z @yaqiangz @Blueve Can you kindly help review this PR, thanks in advance!

asraza07 avatar Jun 13 '24 06:06 asraza07

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: asraza07 / name: Asad Raza (46aacbba60879e1c7aa33019fc2556d74040a2e5, 7c6b91170e51297e0b35c59415ba80945d80e731, 6db53699afab51d1b00d9878b2ec1117e9820b36, fe661f4eebc9e2df9144a8937e2d8d8ef6d3415d, b0aab5355ebd3e37a3161434046dcafdbbc2eabb, e7450ec59d2136135bb4ca245998213e3a2bc741, 7235c25cab98a82cd9a189073b11b78dc966711c, d3421b73abc26be3e7c4f4b9aa4e4a56724ef071, b6c336dd2559413ad6f0ed48c8aaadede758daf5, 42e43b10f7da55f6c12df3f48c1e24c37bf5ce6a, 62a6782afeed10572280b93b1ce98ae6e1962ad8, 0f36f9575b86f4c9911f7806b45ebc64e2482151, 8afda8e4dd68c9f9f9f4146481745808cf510481, 87948cbc89678e76f5546a8e3a89d28815ea6de6, 7c16a8975369c5ea7fda867c2c48cd8f23c089b5, a71524bece49fe8119856b29c942d22b56b5a631, 7756dde07bb1ee403873bc96395c6040daead3c8, 271a0ed1f8abe5c7810325ee92dae7d078a2ba55, 1ffc299be429a3051cb48a7d9f9c1c78c15ab6ca, 6a43338123b592d1a1ed4222cd7e7cc53e917031, 6193bda274f2ca328851562f87b91e696a69601d, 594476becb2dc19583c9cd0eeb2a3cc50bab79fd, e2ae103056bc6fdec11fb59b215f3f219b1c80e2, 08110099dcf03cdf92efff81b265ed4be07bd3f7, 81b73bac1aaf5292d3dfddf61536aa5e4861cc30, 86808aeb0fd8723cebf3dd15f8facc288a0978d5, 002ea716541acdac3d99c37aead562ec0951d3e5, 4ed287a281b249079c89f0b72cf0f87d76ffb038, d71e6fcf3fe5ced76761035acb53a0ed7b7f8138, 95765f9f595ccf75b9b80b48f39f382d6674fdbb, 5a6b56a822c8af9f9b472753c71fa9ab47a4bc4f, 347850fc6730dffe67dec1a97da4c2f0a211a736, 7ac19268b0f43396bc4bf073f6c708245464f7b0, 47e4d8940ee3c61ceda98f48d86088ba1d9a0d47, d748f5559204f72f0b27ab98417ebaf90dffa28b, 31a1248950d479be35c5cb0bb3502b68ac84e8d4, 790d8f93867792928b217e6b6c83700b1b1f2921, fe99f6f309185c4c946f71eddd80024956459f2d, 86402dbf9017c4d23155a51e45260503a744c43b, 9c2f81e95084abac76ce2349270f9bc8be820116, 6866f2ff92e9ebb7f564dc345a770ffbe80c4eb6, 4bab065dec28f8b597f81ced1f64dd5ee9c10093, 4d895165e6f0b742a8124278da237b7eca94cd3f, 169a75e7ab63c287ffe13784bbb02dd316f19a88, 59d020c304e5f152fc0be3dec61b4cf4406cdb7a, d577a8ca4992c19f5fe84520b5807631548c5048, 5113a36d45e635af0ffde627d416f807f954cfd4, 8c5fb8fb02f74d7602031e01b7e093e40f62e7c9, 55225309ec649ae7a2c37d5daaa8202db32fd03a, 7f01ed23d2a712d726eb9cfbc5a2d2306b904b00, 35b98abf9e3ff2ad926338969091c6f2c62feaa0, a156ebcf7d0c6f0bb49c86d3e5ccacd3b311376c, baed48ac0d8a1a26b09649967c890a9c23de1783, 277dc740bf3d202381a870e6e15d462295512fdc, b75d973175d1778258781cf0f853aba20458a9a1, 66260c745082137e90f927e108ae0d0923ace934, 1c061715de35544e30fec2fc4fa2aacccdf43da2, ee95cfe7596e36c518815a56285a807b0fb2b2be, 7d7562c0b7192b1630ac6ad0845ee92f8587d020, 628a770ca5d1b93a09265a389432d07adf4eadd0)
  • :white_check_mark: login: ridahanif96 / name: Rida Hanif (6e136a0d7f4e93e6557a17dabb62823f1b420248, b06482ee07e934d682fb62800a5fa0d5db739b68, 6cd94ca51defd0060fc067ac7500e572b71ca690, 4cc58a31939f54289b26eaaae72e024f2728abb2, e4cadde1adadfa1e5090fe4f2a15302b3eb2529f, 81a86d2200467992624b6bc35f6f88cca9f32851, d9767b26033d3a45101986b3931cc5cf44ca0acd, 7adbbf87c2eaa369cac0cb5d6e07aaa13ac97a07, 1047c6f9a9157f8beafa387c8028788d56e31b78, 3adaf984fff1c31f3b44d64d33a2d0516651d414, c85d89ce0a8d9a544a0711ba12b562d8e91a0d3e, f0d2fcecb64a7ba1f3af54706382a9dbf39d65c4, f8c2ab049cb0dc873bbafb9052d50831ce6e6b6d, 2b9868c2317d173ad29c453fcff8a089c2fd1aba, de19535346365a9fe39fe4bc9806e934dd667589, 1d54e22eabe4d846070ea4a35f8d01ece4e1cc0c, 614cc5cfafbeb6237fb23c74ea6cd69f133c4762, 8dfb30948cba70fd77e19e730b8eb01ea67d307b, 41b51e2e3dc056243b245d8ae169b1dc9e69117e, 82f498db7a0a330b10c22b349664b21e6b93aaba, 7bfe23a6ba7f13fb6c91c668abb1f2d1b6a02234, 5ff01ea8904f93d91d9a659037cd6822e0ccf984, 98b7ddd61ccb92605f0e62672feb7a5021b5d868, a10976c20604a0904c8b2862b2addba358c1da2c, 271dd49956ac790563f66e070b895dc7d1fa5dba, 6db15aa073e4c45e026138ecd9def5c3195b90e7)
  • :white_check_mark: login: KanzaLatif / name: Kanza Latif (85329800f193c65b1ac036678304042d168da625, 32f932df5fe4a22f0aa1b71e843b168323f32701, b0fe8f213072b64950f4d2262509d3d711e14bfe, a3ebe6518a9330563e4bf89bee3ed1dc4ed9038d, d85648ccce58ccd17cf59721c7a754b8eeca224d, 3a6c4a67ea09ab3c3bf6d1de3c5f7401b45031f8, 21cab1aea32957e5b94597fc2757735169b86537, f3cd62d29b93ce8600d2cbd535ebc59a17382ccb, e81892cd4ca3b01ab0f74bca7e30b280970bfc3d, 9a10c79f711ab10e9d1d30c868c7e7a1db516403, 3d581d786f767c66b8c9b07810896a8cc7e2389b, 85f10e4f98caa314df2c0d8612dbf8242e39cdce, 624caf39662d3ecbfb8d434c53c4cfcefdf3ad97, 0c6c8577f7f00b8053b7997f664b091bfe9f7f5d, 7ad873aa752add85691b8148957ad07409a74a93, 6637b21ad88051f6960e186ef32ec314aaae0eb6, c8f6a9b39abe1edbeae3cc7e12e70b8d416daad7, f709832cbe1102e6786cc87122eb84dac591da09, 49532cdab985f5b1ee9fb3b913a87176716d62d2, 345ccec6a0c15d454149842ff7449780126954a6)
  • :white_check_mark: login: muhammadalihussnain / name: Muhammad Ali Hussnain (f5e7f8a04f4345e5a9269fab3c017aa8bb17b62b, 1a69d1665533a4c3dca2b149b8eddc14a760cfc1, 0148cda83d9a67bb4f23db9367ce2d5430a85645)

@yaqiangz Can you help approved this PR. We are also done with Code Coverage. Thanks in advance!

ridahanif96 avatar Jul 23 '24 04:07 ridahanif96

@qiluo-msft Pls help review this PR. HLD Already Approved. Thanks in advance!

ridahanif96 avatar Jul 23 '24 04:07 ridahanif96

Hi @qiluo-msft can you pls help review this PR. HLD is merged

ridahanif96 avatar Aug 23 '24 04:08 ridahanif96

@qiluo-msft pls help merge this one

ridahanif96 avatar Sep 18 '24 12:09 ridahanif96

@qiluo-msft please help review and merge this PR

ridahanif96 avatar Oct 14 '24 09:10 ridahanif96

Please resolve conflict #Closed

qiluo-msft avatar Oct 17 '24 19:10 qiluo-msft

Please resolve conflict

Resolving! Thanks for help

ridahanif96 avatar Oct 18 '24 11:10 ridahanif96

/azpw run

ridahanif96 avatar Oct 23 '24 12:10 ridahanif96

/azpw run

asraza07 avatar Oct 23 '24 12:10 asraza07

/AzurePipelines run

mssonicbld avatar Oct 23 '24 12:10 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 23 '24 12:10 azure-pipelines[bot]

@qiluo-msft conflicts has been resolved can you please help review and merge!

ridahanif96 avatar Oct 24 '24 11:10 ridahanif96

@qiluo-msft , Hi Qi, PR has been approved since so long and updates as per your suggestions are also done.

Kindly merged this PR..

ridahanif96 avatar Dec 01 '24 02:12 ridahanif96

@qiluo-msft

Hi Qi, Suggested changes have been catered as per your suggestions. Kindly review to merge this PR.

wajahatrazi avatar Dec 04 '24 07:12 wajahatrazi

@qiluo-msft help merge this PR, pending for long, unable to understand merge delay!

ridahanif96 avatar Dec 14 '24 20:12 ridahanif96

@qiluo-msft this PR has been approved by reviewers, can you please check if this can be merged? Thanks.

zhangyanzhao avatar Jan 21 '25 03:01 zhangyanzhao

/azp run

mssonicbld avatar Feb 05 '25 12:02 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 05 '25 12:02 azure-pipelines[bot]

@qiluo-msft this PR has been approved by reviewers, Please help to merge this PR? Thanks.

muhammadalihussnain avatar Feb 06 '25 04:02 muhammadalihussnain

@qiluo-msft this PR has been approved by reviewers, Please help to merge this PR? Thanks.

muhammadalihussnain avatar Feb 20 '25 12:02 muhammadalihussnain