sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

[Logrotate] Add config and show commands

Open fastiuk opened this issue 1 year ago • 5 comments
trafficstars

depends-on #783

What I did

Added CLI commands for Banner feature according to HLD: TBD

How I did it

Added CLI commands to:

  • Configure logrotate feature: disk percentage, frequency, max number, size
  • Related show command

How to verify it

Manual testing

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

fastiuk avatar Apr 27 '24 22:04 fastiuk

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: fastiuk / name: Yevhen Fastiuk (110cb4304ae437b5699e801ba19aab7638b3e573, b101a6463bff5b4c9fc567eb7bbc136f9371fb2d, f5adf03d01d81c993c7c414286f5fc7362d84e6f, fb95e498c362c427ac2c20e249c41b73499b8a2d, f4ae104e1fd606f779b8dbe275bbd51b957d421c, d2381410cc80bea60c062e7b23ef8551ec1d0cde, 5f4431e12e2faa61d0e82476863d0c0ae5e08ae0, d7cbec97685bee6a2ffa119c7d39b1a1a434aebf, 396629220c37e4e0970eb363faf0dae54d20f2cd, c0ccc47ef17eb9e094c49ab3adcc515e4678b88f, e2e45395fcf45fd23844cce81c3bc5cc924d8810, da2df2758173535323b124b39dadaa85e4d14888, b7e5ebf551bd987f4f5406289ed4b48846474b90, 7c487c50b29b0dfde0adc5bb6cbdce263d80e623, 6dab93b71c9408edd22ef9a868785f9bac6e8ff3)

linux-foundation-easycla[bot] avatar Apr 27 '24 22:04 linux-foundation-easycla[bot]

@dgsudharsan could you please help to review? @fastiuk could you please followup on checkers and ensure all is passing?

liat-grozovik avatar Jul 09 '24 16:07 liat-grozovik

@fastiuk the command reference guide should be updated with the CLI changes in the same PR

liat-grozovik avatar Jul 09 '24 16:07 liat-grozovik

Tests will fail until https://github.com/sonic-net/sonic-swss-common/pull/783 is merged

fastiuk avatar Aug 14 '24 12:08 fastiuk

Tests will fail until https://github.com/sonic-net/sonic-swss-common/pull/783 is merged

fastiuk avatar Oct 07 '24 16:10 fastiuk

@saiarcot895 please merge if you can, CI passed here

fastiuk avatar Jan 06 '25 14:01 fastiuk

@saiarcot895 many thanks. Please merge as well if you have rights for that

fastiuk avatar Jan 11 '25 08:01 fastiuk

@liat-grozovik could you please merge this PR? All checkers are passed, and it is approved

fastiuk avatar Jan 13 '25 17:01 fastiuk

@qiluo-msft , Can you please assist with PR merge ?

dprital avatar Jan 30 '25 02:01 dprital