sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

[Banner] Added CLI commands to configure Banner and display current configuration

Open SviatoslavBoichuk opened this issue 2 years ago • 13 comments
trafficstars

What I did

Added CLI commands for Banner feature according to HLD: https://github.com/sonic-net/SONiC/pull/1361

How I did it

Added CLI commands to:

  1. Enable/disable Banner feature
  2. Configure Banner messages: login/motd/logout
  3. Related show command

How to verify it

Manual testing

Previous command output (if the output of a command-line utility has changed)

N/A

New command output (if the output of a command-line utility has changed)

N/A

SviatoslavBoichuk avatar Oct 20 '23 14:10 SviatoslavBoichuk

@SviatoslavBoichuk i am missing command reference guide updates. please update it based on the new proposed CLI commands

liat-grozovik avatar Dec 03 '23 13:12 liat-grozovik

@SviatoslavBoichuk i am missing command reference guide updates. please update it based on the new proposed CLI commands

Added Commands to Command Reference Quide.

SviatoslavBoichuk avatar Dec 15 '23 10:12 SviatoslavBoichuk

The test is failing because https://github.com/sonic-net/sonic-swss-common/pull/826 should be merged first

fastiuk avatar Apr 22 '24 14:04 fastiuk

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: fastiuk / name: Yevhen Fastiuk (197e49aab42590d328016a5db2893b9b23a10f69, 8040d7e0af23d5e28b8d2185a445ad3f966209b5, 7a7f9f7e71d875cb8cdc09009a4ac9c43acd240e, 1ae2d63988ee5828e2284dc02bbeaecb1bc26fd5)

linux-foundation-easycla[bot] avatar Apr 27 '24 21:04 linux-foundation-easycla[bot]

@qiluo-msft kindly review the comments and lets close the review loop. @fastiuk please followup on PR checkers. lets ensure all passing

liat-grozovik avatar May 07 '24 11:05 liat-grozovik

@qiluo-msft kindly review the comments and lets close the review loop. @fastiuk please followup on PR checkers. lets ensure all passing

Checkers are not passing because sonic-swss-common PR must be merged first

fastiuk avatar May 07 '24 11:05 fastiuk

@qiluo-msft conflicts were resolved. Please re-review/approve.

fastiuk avatar May 14 '24 21:05 fastiuk

@qiluo-msft rebased with the master. Please re-review/approve.

fastiuk avatar May 20 '24 10:05 fastiuk

@qiluo-msft , gentle reminder :)

fastiuk avatar May 30 '24 13:05 fastiuk

@qiluo-msft , gentle reminder :)

fastiuk avatar Jun 03 '24 14:06 fastiuk

@qiluo-msft , gentle reminder :) Please approve this as well, as 2 out of 4 were merged already

fastiuk avatar Aug 28 '24 09:08 fastiuk

@SviatoslavBoichuk , we are interested in the banner feature. can it be merged anytime soon?

jhli-cisco avatar Aug 29 '24 18:08 jhli-cisco

@SviatoslavBoichuk , we are interested in the banner feature. can it be merged anytime soon?

It should be merged soon. We are waiting for the review/approve

fastiuk avatar Sep 09 '24 12:09 fastiuk