sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

[config, show] Add CLI commands for Path Tracing Midpoint

Open cscarpitta opened this issue 2 years ago • 8 comments

What I did

Extended the SONiC CLI to configure Path Tracing Midpoint. HLD: https://github.com/sonic-net/SONiC/pull/1456

How I did it

  • Extended the existing config interface command by introducing a new subcommand path-tracing that allows users to configure the Interface ID and Timestamp Template parameters required for the PT Midpoint functionality.
  • Extended the existing show interfaces command by introducing a new subcommand path-tracing that allows users to verify the current PT Midpoint configuration (i.e., the Interface ID and Timestamp Template).

How to verify it

Unit tests:

  • tests/config_int_path_tracing_test.py
  • tests/intfutil_test.py

cscarpitta avatar Sep 15 '23 14:09 cscarpitta

@prsunny @kperumalbfn could you please help and review the code of this PR? This feature is tracked for 202311 release and documented by this HLD https://github.com/sonic-net/SONiC/pull/1456 @zhangyanzhao

ahsalam avatar Oct 14 '23 09:10 ahsalam

@kperumalbfn Many thanks for the review. All comments have been addressed.

cscarpitta avatar Oct 31 '23 11:10 cscarpitta

Hi @lguohan @qiluo-msft This PR has been reviewed and approved. It is ready for merge. Could you please merge the PR?

cscarpitta avatar Nov 16 '23 20:11 cscarpitta

@kperumalbfn Could you please advice who should merge the code?

cscarpitta avatar Nov 28 '23 15:11 cscarpitta

@cscarpitta , there are conflict, can you rebase?

lguohan avatar May 15 '24 16:05 lguohan

@qiluo-msft can you please help to check and merge this code PR? Thanks.

zhangyanzhao avatar May 22 '24 16:05 zhangyanzhao

@qiluo-msft @lguohan

The orchagent extension PR to support Path Tracing has been merged: https://github.com/sonic-net/sonic-swss/pull/2903

Can you please take a look and help merge this PR as well?

cscarpitta avatar May 24 '24 17:05 cscarpitta

@qiluo-msft, @zhangyanzhao,

This PR has been pending merge for some time now. Could we merge this as part of 202411?

The HLD (Oct 2023) and Orchagent (May 24) has been merged. HLD: https://github.com/sonic-net/SONiC/pull/1456 Orchagent: https://github.com/sonic-net/sonic-swss/pull/2903

ahsalam avatar Aug 08 '24 15:08 ahsalam