sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

[system-health] Improve code structure of system health CLIs

Open Junchao-Mellanox opened this issue 2 years ago • 2 comments

What I did

Improve code structure of system health CLIs

How I did it

Remove duplicate code

How to verify it

Existing unit tests all passed

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Junchao-Mellanox avatar Oct 25 '22 11:10 Junchao-Mellanox

@qiluo-msft could you suggest someone to review and signoff? LGTM

liat-grozovik avatar Oct 30 '22 08:10 liat-grozovik

@qiluo-msft kindly reminder to get your review feedback

liat-grozovik avatar Nov 09 '22 13:11 liat-grozovik

Hi @qiluo-msft , kindly reminder to get your review feedback

Junchao-Mellanox avatar Nov 28 '22 01:11 Junchao-Mellanox

@Junchao-Mellanox please update the section:- `

  1. Previous command output (if the output of a command-line utility has changed)
  2. New command output (if the output of a command-line utility has changed) `

prgeor avatar Dec 05 '22 17:12 prgeor

@Junchao-Mellanox please update the section:- `

  1. Previous command output (if the output of a command-line utility has changed)
  2. New command output (if the output of a command-line utility has changed) `

Done.

Junchao-Mellanox avatar Dec 06 '22 01:12 Junchao-Mellanox