sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

Add SAG implementation

Open superchild opened this issue 3 years ago • 19 comments

What I did

  • Add static anycast gateway related commands support. Refer to SAG HLD#837

How I did it

  • Add new commands
    • config static-anycast-gateway mac_address add/del
    • config vlan static-anycast-gateway add/del
  • Add unit test cases

How to verify it

  • Executing unit tests

Signed-off-by: Jimi Chen [email protected]

superchild avatar Oct 20 '21 07:10 superchild

@cbpaviz Thanks for your comments, codes are modified according that. Please help to check and review again.

superchild avatar Nov 15 '21 07:11 superchild

/azpw run

superchild avatar Dec 06 '21 03:12 superchild

/AzurePipelines run

mssonicbld avatar Dec 06 '21 03:12 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 06 '21 03:12 azure-pipelines[bot]

/azp run

superchild avatar Dec 07 '21 01:12 superchild

Commenter does not have sufficient privileges for PR 1887 in repo Azure/sonic-utilities

azure-pipelines[bot] avatar Dec 07 '21 01:12 azure-pipelines[bot]

/azpw run

superchild avatar Dec 07 '21 01:12 superchild

/AzurePipelines run

mssonicbld avatar Dec 07 '21 01:12 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 07 '21 01:12 azure-pipelines[bot]

@cbpaviz Could you help to review again, I merged the code from master branch due to some confict.

superchild avatar Dec 10 '21 05:12 superchild

/azpw run

superchild avatar Dec 15 '21 00:12 superchild

/AzurePipelines run

mssonicbld avatar Dec 15 '21 00:12 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 15 '21 00:12 azure-pipelines[bot]

/azpw run

superchild avatar Dec 15 '21 01:12 superchild

/AzurePipelines run

mssonicbld avatar Dec 15 '21 01:12 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 15 '21 01:12 azure-pipelines[bot]

/azp run

yxieca avatar Dec 27 '21 17:12 yxieca

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 27 '21 17:12 azure-pipelines[bot]

@cbpaviz Could you help to review again? Thanks.

superchild avatar May 06 '22 13:05 superchild

@cbpaviz Could you help to review again, I merged the code from master branch due to some conflict.

superchild avatar Feb 22 '23 01:02 superchild

@superchild , why SAG config commands are different compare to EC config commands (available in their config guid). is it intentional ?

kulpatel avatar Feb 27 '23 06:02 kulpatel

@kulpatel, this PR is discussed and reviewed by community, EC will also follow the same design after this merged. The original design is slightly different from community's opinion.

superchild avatar Mar 01 '23 01:03 superchild

@zhangyanzhao Sorry for the wrong operation sync, this PR's commit history is gone. I already reset the commit on my dev branch, could you please reopen this PR? Or should I resend a new PR for it?

superchild avatar Jun 16 '23 03:06 superchild