sonic-telemetry icon indicating copy to clipboard operation
sonic-telemetry copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

Fix Dial-out Insecure Mode

Open TildenWinston opened this issue 4 years ago • 4 comments

Adds support for insecure mode for testing and development purposes to telemetry dial-out. Based on the changes authored by @liuqu in PR #14 . Previously -insecure failed to connect to collectors running on windows systems, but this fixes this issue.

Dial-out client: Fixes insecure mode

  • Fixes insecure mode
  • adds skip_verify flag

TildenWinston avatar Aug 03 '20 01:08 TildenWinston

CLA assistant check
All CLA requirements met.

ghost avatar Aug 03 '20 01:08 ghost

what test have been conducted for this change? And does all utest still work?

hui-ma avatar Aug 13 '20 07:08 hui-ma

how to config config DB to enable new flag or the new flag should not be enabled in config DB as all?

The change is to the command line arguments only. The change is not reflected in the CONFIG_DB. See #43 which is a new PR to add documentation for the command line arguments for more information.

TildenWinston avatar Aug 14 '20 02:08 TildenWinston

what test have been conducted for this change? And does all utest still work?

I was unable to unit tests working with or without this update. I have tested manually. image

Manual tests include: Dev VM to C# Collector (Both secure and insecure) Tested as an additional service on real SONiC device to C# Collector (Secure) Dev VM to Golang Dial-out collector (Insecure, Insecure with tls_disable on both sides, Secure)

TildenWinston avatar Aug 15 '20 05:08 TildenWinston