sonic-swss
sonic-swss copied to clipboard
sonic-net
[sonic-swss]: Added flap counter and last flap time functionality.
Number of times a link got reset(up/down) has been added under this change, also the last flap timestamp for the link has also been added, they will be updated once the oper status of any port changes. 2 additional fields have been added to appl_db i.e. "flap_counter" and "last_flap_time" which willbe updated when "oper_status" is updated.
Signed-off-by: Prem Prakash [email protected]
What I did Added flap counter and last flap timestamp feature
Why I did it This would help in solving operational issues faster. Instead of relying on the logs to figure out a bad flapper we can see this feature under status command.
How I verified it Tested it by building up the docker-orchagent.gz after my change, changes were required on sonic-utilities repo as well to see the output, I will raise a parallel PR for that.
redis incr is nice but it requires much more changes. i suggest a design review first
how to move forward on this one? schedule a call to discuss this feature? @prprakas to schedule?
@lguohan @stcheng Yeah we can schedule a call to discuss on this. I am based out of Bangalore, India so let me know what is the good time to talk to you
@lguohan will add a vs-test for this, I think that should be good to move ahead with this as per the communication from @zhenggen-xu
@prprakas , can you fix simply comments we have requested, also can you share the ETA for adding vs test?