sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

[FC] process FC after apply view

Open stepanblyschak opened this issue 1 year ago • 3 comments

What I did

Simplify approach to delaying counters on warm boot and fast boot. Removed FLEX_COUNTER_DELAY_STATUS_FIELD and instead postpone all FC processing to happen after apply view to not delay data plane configuration.

The CONFIG_DB should not be updated in runtime anymore for counters to be delayed.

Why I did it

To address https://github.com/sonic-net/sonic-buildimage/issues/20302.

How I verified it

Run warm-boot - make sure FC orch runs only after APPLY_VIEW.

Details if related

stepanblyschak avatar Oct 14 '24 11:10 stepanblyschak

/azpw run

stepanblyschak avatar Oct 14 '24 14:10 stepanblyschak

/AzurePipelines run

mssonicbld avatar Oct 14 '24 14:10 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 14 '24 14:10 azure-pipelines[bot]

Putting back delay for 60 sec as we found some cases where oper state update handling is delayed due to FC configuration after APPLY_VIEW

stepanblyschak avatar Nov 13 '24 19:11 stepanblyschak

@wen587 Can you help review?

bingwang-ms avatar Nov 21 '24 17:11 bingwang-ms

@qiluo-msft @stepanblyschak can we close the review and have it before 202411 is branched out?

liat-grozovik avatar Dec 03 '24 17:12 liat-grozovik

/azpw run

stepanblyschak avatar Dec 09 '24 16:12 stepanblyschak

/AzurePipelines run

mssonicbld avatar Dec 09 '24 16:12 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 09 '24 16:12 azure-pipelines[bot]

/azp run Azure.sonic-swss

bingwang-ms avatar Dec 09 '24 22:12 bingwang-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 09 '24 22:12 azure-pipelines[bot]

Retriggered PR test.

bingwang-ms avatar Dec 09 '24 22:12 bingwang-ms

@qiluo-msft Can you please help review? Thanks

bingwang-ms avatar Dec 09 '24 22:12 bingwang-ms

/azp run

mssonicbld avatar Dec 18 '24 10:12 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 18 '24 10:12 azure-pipelines[bot]

/azp run

mssonicbld avatar Dec 24 '24 10:12 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 24 '24 10:12 azure-pipelines[bot]

/azp run

mssonicbld avatar Jan 15 '25 06:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 15 '25 06:01 azure-pipelines[bot]

/azp run

mssonicbld avatar Jan 17 '25 10:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 17 '25 10:01 azure-pipelines[bot]

Infra issue with tests: failure to install dotnet package:

+ sudo apt-get install -y dotnet-sdk-8.0
Reading package lists...
Building dependency tree...
Reading state information...
E: The package keysinuse needs to be reinstalled, but I can't find an archive for it.

Restarting

stepanblyschak avatar Jan 27 '25 15:01 stepanblyschak

/azp run

mssonicbld avatar Jan 27 '25 15:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 27 '25 15:01 azure-pipelines[bot]

/azp run

mssonicbld avatar Jan 29 '25 15:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 29 '25 15:01 azure-pipelines[bot]

@qiluo-msft @bingwang-ms @vaibhavhd Can be merged?

stepanblyschak avatar Jan 30 '25 13:01 stepanblyschak

/azp run

mssonicbld avatar Jan 30 '25 19:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 30 '25 19:01 azure-pipelines[bot]

/azp run

mssonicbld avatar Feb 05 '25 19:02 mssonicbld