sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

[portsorch] Make exception handling when Remove Bridge fails

Open inspurSDN opened this issue 1 year ago • 4 comments

Why I did it Add static mac 00:00:00:01:01:01 to Ethernet1 (Vlan 100 member) and remove Ethernet1 from Vlan 100, then orchagent process would crash

Jun 28 05:35:41.148167 DUT-1 ERR swss#orchagent: :- meta_generic_validation_remove: object 0x3a000000000a97 reference count is 1, can't remove Jun 28 05:35:41.148167 DUT-1 ERR swss#orchagent: :- removeBridgePort: Failed to remove bridge port Ethernet1 from default 1Q bridge, rv:-17 Jun 28 05:35:41.148174 DUT-1 ERR swss#orchagent: :- handleSaiRemoveStatus: Encountered failure in remove operation, exiting orchagent, SAI API: SAI_API_BRIDGE, status: SAI_STATUS_OBJECT_IN_USE Jun 28 05:35:42.586693 DUT-1 ERR swss#supervisor-proc-exit-listener: orchagent process crash in swss container

What I did Make exception handling when Remove Bridge fails, still let it sync, but try to delete BridgePort again when vlanMember has been deleted.

What I did

Why I did it

How I verified it

Details if related

inspurSDN avatar Jul 02 '24 09:07 inspurSDN

Can you fix coverage?

prsunny avatar Jul 02 '24 17:07 prsunny

@prsunny unitest or dvs ok?

inspurSDN avatar Jul 04 '24 00:07 inspurSDN

@prsunny can you give some advice for Coverage ?

inspurSDN avatar Jul 17 '24 07:07 inspurSDN

@inspurSDN

Azure-Pipelines-Wrapper / coverage.Azure.sonic-swss.vstest failed on Jul 2 in 0s Pull Request Coverage Total: 8 lines Missing: 7 lines Coverage: 12% Threshold: 80%

puffc avatar Oct 08 '24 02:10 puffc