sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

Capability query for MACSEC ACL attribute

Open smvmarvell opened this issue 1 year ago • 1 comments

What I did -Modified the MACsec orchestration logic to conditionally include or exclude the ability to match the SCI in ACL configurations based on the ASIC's capabilities. -Implemented a capability check in SONiC to determine whether the SAI_ACL_TABLE_ATTR_FIELD_MACSEC_SCI attribute is supported by the ASIC, thus ensuring that neither SAI_ACL_TABLE_ATTR_FIELD_MACSEC_SCI nor SAI_ACL_ENTRY_ATTR_FIELD_MACSEC_SCI is used when unsupported.

Why I did it

  • The current implementation attempts to use the SAI_ACL_ENTRY_ATTR_FIELD_MACSEC_SCI attribute even when it's not supported by the underlying ASIC or driver, causing failures in the vendor's SAI/SDK code.
  • The capability check prevents these errors, ensuring compatibility with different hardware.

How I verified it

  • Compiled the code successfully without errors.
  • Conducted manual tests on Marvell platforms without support for the SAI_ACL_TABLE_ATTR_FIELD_MACSEC_SCI attribute to validate the conditional logic.

Details if related Fixes the issue raised in https://github.com/sonic-net/sonic-swss/issues/3134

smvmarvell avatar May 07 '24 08:05 smvmarvell

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: smvmarvell (427913c655a8569015c272a5fde1b0d01634f420)

This change is already merged as part of https://github.com/sonic-net/sonic-swss/pull/3385.

gurugmarvell avatar Jan 17 '25 08:01 gurugmarvell

@prsunny , Could you please close this PR , this change is merged as part of https://github.com/sonic-net/sonic-swss/pull/3385.

gurugmarvell avatar Jan 17 '25 08:01 gurugmarvell