sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

Do not apply zero buffer profile list until all buffer pools are ready

Open stephenxs opened this issue 10 months ago • 2 comments

What I did

It was harmless unless there were too many messages indicating the depending buffer pools and profiles on some certain platforms, which triggers the syslog rate limit.

Signed-off-by: Stephen Sun [email protected]

Why I did it

How I verified it

Manual and mock test

Details if related

stephenxs avatar Apr 12 '24 11:04 stephenxs

LGTM. @stephenxs the PR is just pending final testing and ready for review? @prsunny could you please review or suggest someone who can?

liat-grozovik avatar Apr 16 '24 08:04 liat-grozovik

@liat-grozovik , please move to 'ready' from 'draft'. @neethajohn to review

prsunny avatar Apr 16 '24 17:04 prsunny

@prsunny we would like to have the fix in 202305 and 202311. please let us know if this can be backport. @bingwang-ms FYI

liat-grozovik avatar Jul 16 '24 13:07 liat-grozovik

enhancement, no cherry pick to 202305.

StormLiangMS avatar Aug 02 '24 08:08 StormLiangMS

enhancement, no cherry pick to 202305.

Hi @StormLiangMS When the issue happens, there are a large number of messages, causing the system to drop messages from orchagent. As a result, some important message can be lost.

stephenxs avatar Aug 06 '24 02:08 stephenxs