sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

Apply port speed again after disabling port AN

Open PJHsieh opened this issue 1 year ago • 1 comments

What I did Apply port speed again after disabling port AN.

In PortsOrch, when autonegotiation is disabled for a port, this PR ensures that the port speed is updated correctly. If a new speed is configured while autonegotiation is disabled, the new speed is applied; otherwise, the current speed setting is reconfigured.

Why I did it In PortsOrch, the port speed configuration will not be set to SAI when port AN is enabled. Changing the port speed while port AN is enabled will not take effect after port AN is disabled.

In some chips, the port speed can not be modified when port AN is enabled.

How I verified it

  1. Enable port AN.
  2. Set port speed from speed1 to speed2
  3. Disable port AN.
  4. Make sure port speed is speed2 instead of speed1.

Details if related

PJHsieh avatar Mar 28 '24 02:03 PJHsieh

Hi, @prgeor , @prsunny , the test error is fixed.

Please review and approve this PR.

PJHsieh avatar May 02 '24 08:05 PJHsieh

/azp run

mssonicbld avatar Jan 08 '25 07:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 08 '25 07:01 azure-pipelines[bot]

/azp run

mssonicbld avatar Jan 09 '25 02:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 09 '25 02:01 azure-pipelines[bot]