sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

[orchagent] Support for aggregrate VOQ Counters.

Open vivekverma-arista opened this issue 1 year ago • 10 comments

What I did

Implemented aggregate VOQ counters support according to aggregate VOQ counters HLD #1578

Why I did it

Part of aggregate VOQ counter feature support #1543

How I verified it

Sent traffic to the switch and checked that VOQ stats are getting populated in CHASSIS_APP_DB

vivekverma-arista avatar Feb 13 '24 07:02 vivekverma-arista

@vivekverma-arista Can you please do test to send traffic from multiple sources to single destination and see if the aggregation is happening properly in the CLI o/p ?

vmittal-msft avatar Feb 28 '24 21:02 vmittal-msft

Also, Can we have command format like - show queue counter --voq <Interface> as it will be in-line with following -

show queue counters <Interface>

vmittal-msft avatar Feb 28 '24 21:02 vmittal-msft

please rebase and bring to latest.

vmittal-msft avatar Feb 28 '24 22:02 vmittal-msft

@saksarav-nokia please review as well

judyjoseph avatar Mar 06 '24 18:03 judyjoseph

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: vivekverma-arista / name: Vivek Verma (fe29d7c5f56422fe82bfe5f726cea24e0250daf4, cb6b9684d1549e036da93679b50adb33d95215b8, 3f067f6b4fc46e96746796a0f4efb425f5052fd7, 8a9e3c6dff7d25cc2676418f83b087bb5cd74e01)
  • :white_check_mark: login: prsunny / name: Prince Sunny (3a54c412e8ab9faf36260d4e5bed3de47cd9d3d6, f625dbe543288c3facae532f258dce56ab0afce0)
  • :white_check_mark: login: viveksrao-arista (72aafec6852e165c7ed9bf3c32b625326f6fb2d7, 3df86c237ea55184c68a4aa69fe2fae0b209176a, 0465818e79b1b5bfb7019ed43f8af70e8a797f3f, 789eafb1b9236c977de62e0db436c871e41f1f57)

linux-foundation-easycla[bot] avatar May 16 '24 11:05 linux-foundation-easycla[bot]

Please update the code as it is out of date. @viveksrao-arista, Is this change to maintain mapping of VoQ to system port ? To be needed while updating the data to chassis_app_db ?

vmittal-msft avatar May 24 '24 19:05 vmittal-msft

@kenneth-arista @saksarav-nokia

vmittal-msft avatar May 24 '24 19:05 vmittal-msft

Please update the code as it is out of date. @viveksrao-arista, Is this change to maintain mapping of VoQ to system port ? To be needed while updating the data to chassis_app_db ?

Yes, this table maps a VoQ to system port and is used to obtain the interface name to which the VoQ belongs to when updating chassis_app_db.

viveksrao-arista avatar May 25 '24 06:05 viveksrao-arista

@viveksrao-arista please rebase it.

vmittal-msft avatar May 29 '24 15:05 vmittal-msft

@viveksrao-arista please rebase it.

Rebased the code.

viveksrao-arista avatar May 30 '24 03:05 viveksrao-arista

@vivekverma-arista please re-base

vmittal-msft avatar Jul 08 '24 22:07 vmittal-msft

@vivekverma-arista : Please update PR description on which HLD Component this PR is targetting.

abdosi avatar Aug 07 '24 17:08 abdosi

@saksarav-nokia

abdosi avatar Aug 07 '24 17:08 abdosi

We have changed the approach to be taken, hence closing this pull request.

HLD has been updated with the new approach and new PR will be opened.

vivekverma-arista avatar Aug 28 '24 15:08 vivekverma-arista