sonic-swss
sonic-swss copied to clipboard
sonic-net
[orchagent] TWAMP Light orchagent implementation
What I did Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(https://github.com/sonic-net/SONiC/pull/1320).
Why I did it Part of the TWAMP Light feature support.
How I verified it It Implemented VS test.
Details if related sonic-swss-common: https://github.com/sonic-net/sonic-swss-common/pull/823 sonic-sairedis: https://github.com/sonic-net/sonic-sairedis/pull/1306
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@prsunny PR has been rebased and all conflicts have been resolved. Could you please help to review & merge, thanks.
@prsunny kindly reminder. Could you please review or assign someone to review the PR, thanks
@prsunny This PR is very important for TWAMP Light. And PR (https://github.com/sonic-net/sonic-sairedis/pull/1306) has been merged. We expect TWAMP Light to be pushed in the release version of 202405. So please help to review this PR or invite others to review it. And If you can merge it, please help to merge. Thanks very much.
What I did Implemented the TWAMP Light feature according to the SONiC TWAMP Light HLD(#1320).
Why I did it Part of the TWAMP Light feature support.
How I verified it It Implemented VS test.
Details if related sonic-swss-common: sonic-net/sonic-swss-common#823 sonic-sairedis: sonic-net/sonic-sairedis#1306
Can you please fix the link for HLD?
@huseratgithub , as mentioned in HLD PR, i cannot find a sonic-mgmt PR for this feature? Do you plan to provide one?
@huseratgithub , as mentioned in HLD PR, i cannot find a sonic-mgmt PR for this feature? Do you plan to provide one?
@prsunny This is the initial commit for phase 1. I plan to do sonic-mgmt in later phase.
Please rebase to latest master and fix the coverage issue.
Hi @prsunny , The code coverage check passed.
@prsunny Many thanks for the review. All comments have been addressed. Could you please help to approve this PR ? Thanks.
@prsunny just a kind reminder. This is for SONiC 202405 Release and also CLI is ready, so it is better to complete before branch out. Please help to approve or to assign someone on behalf of you. Thank you very much.
Can you please rebase?
Hi @prsunny , thank you for the reminder. I have rebased to latest now, please review and approve.
@huseratgithub , @prsunny ,Please help with PR validation failure. https://github.com/sonic-net/sonic-buildimage/pull/18334
@huseratgithub , @prsunny ,Please help with PR validation failure. sonic-net/sonic-buildimage#18334
Thank you for the reminder. It looks like 'hw_stats' uninitialized. fixed. https://github.com/sonic-net/sonic-swss/pull/3115