sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

[fpmsyncd] Fpmsyncd Next Hop Table Enhancement

Open ntt-omw opened this issue 1 year ago • 10 comments

What I did Implementing code changes for https://github.com/sonic-net/SONiC/pull/1425

Why I did it add nexthop group feature to fpmsyncd.

How I verified it

enable/disable nexthop group feature

  • Klish will call REST API to configure feature next-hop-group enable.
  • FEATURE|nexthop_group will be created in CONFIG_DB
    • template zebra.conf.j2 will generate zebra.conf with fpm use-next-hop-groups if FEATURE|nexthop_group exists in CONFIG_DB. Else, it will generate zebra.conf with no fpm use-next-hop-groups (default behavior)
  • Do config save comman and write to /etc/sonic/config_db.json
  • restart SONiC: virsh reboot sonic-nhg
  • /etc/frr/zebra.conf has fpm use-next-hop-groups instead of no fpm use-next-hop-groups

Klish CLI for feature nexthop_group

  • Enable: sonic(config)# feature next-hop-group enable
  • Disable: sonic(config)# no feature next-hop-group

Enable

admin@sonic:~$ sonic-cli

sonic# configure terminal

sonic(config)#
  end        Exit to EXEC mode
  exit       Exit from current mode
  feature    Configure additional feature
  interface  Select an interface
  ip         Global IP configuration subcommands
  mclag      domain
  no         To delete / disable commands in config mode

sonic(config)# feature
  next-hop-group  Next-hop Groups feature

sonic(config)# feature next-hop-group
  enable  Enable Next-hop Groups feature

sonic(config)# feature next-hop-group enable
  <cr>

Disable

sonic(config)# no
  feature  Disable additional feature
  ip       Global IP configuration subcommands
  mclag    domain

sonic(config)# no feature
  next-hop-group  Disable Next-hop Groups feature

sonic(config)# no feature next-hop-group
  <cr>

Details if related

ntt-omw avatar Oct 02 '23 10:10 ntt-omw

/AzurePipelines run Azure.sonic-swss

nakano-omw avatar Nov 15 '23 04:11 nakano-omw

Commenter does not have sufficient privileges for PR 2919 in repo sonic-net/sonic-swss

azure-pipelines[bot] avatar Nov 15 '23 04:11 azure-pipelines[bot]

@zice312963205 @shuaishang Please help in restarting the /AzurePipelines run Azure.sonic-swss. Would you be able to grant me the privilege?

nakano-omw avatar Nov 15 '23 04:11 nakano-omw

@nakano-omw your branch needs to be updated and you need to repush your code first. @prsunny Hi Prince, can you please help with this PR to merge. Thanks.

ridahanif96 avatar Dec 15 '23 04:12 ridahanif96

@ridahanif96 I have repush. Thanks.

nakano-omw avatar Dec 15 '23 11:12 nakano-omw

Looks good

zice312963205 avatar Jan 18 '24 09:01 zice312963205

reviewers, can you please help to review and approve this PR? Thanks.

zhangyanzhao avatar Feb 05 '24 08:02 zhangyanzhao