DASH: ENI removal produces errors in the log

[Yakiv-Huryk]

Orchagent produces errors from meta_generic_validation_remove()/meta_sai_validate_eni_ether_address_map_entry() when removing an ENI:

NOTICE swss#swssconfig: :- main: Loading config from JSON file:/dash_basic_config.json...
NOTICE swss#orchagent: :- removeApplianceEntry: Removed vip and direction lookup entries for 123
NOTICE swss#orchagent: :- removeEniAddrMapEntry: Removed ENI ether address map entry for F4939FEFC47E
ERR swss#orchagent: :- meta_generic_validation_remove: object 0x7000000000006f reference count is 2, can't remove
ERR swss#orchagent: :- meta_sai_validate_eni_ether_address_map_entry: object key SAI_OBJECT_TYPE_ENI_ETHER_ADDRESS_MAP_ENTRY:{"address":"F4:93:9F:EF:C4:7E","switch_id":"oid:0x21000000000000"} doesn't exist
ERR swss#orchagent: :- meta_generic_validation_remove: object 0x7000000000006f reference count is 2, can't remove
NOTICE swss#orchagent: :- removeQosEntry: Removed QOS entries for qos100
ERR swss#orchagent: :- meta_sai_validate_eni_ether_address_map_entry: object key SAI_OBJECT_TYPE_ENI_ETHER_ADDRESS_MAP_ENTRY:{"address":"F4:93:9F:EF:C4:7E","switch_id":"oid:0x21000000000000"} doesn't exist
ERR swss#orchagent: :- meta_generic_validation_remove: object 0x7000000000006f reference count is 2, can't remove
ERR swss#orchagent: :- meta_sai_validate_eni_ether_address_map_entry: object key SAI_OBJECT_TYPE_ENI_ETHER_ADDRESS_MAP_ENTRY:{"address":"F4:93:9F:EF:C4:7E","switch_id":"oid:0x21000000000000"} doesn't exist
ERR swss#orchagent: :- meta_generic_validation_remove: object 0x7000000000006f reference count is 1, can't remove
ERR swss#orchagent: :- meta_sai_validate_eni_ether_address_map_entry: object key SAI_OBJECT_TYPE_ENI_ETHER_ADDRESS_MAP_ENTRY:{"address":"F4:93:9F:EF:C4:7E","switch_id":"oid:0x21000000000000"} doesn't exist
NOTICE swss#orchagent: :- removeEniObject: Removed ENI object for F4939FEFC47E

Steps to reproduce Apply the following (first time with "SET" and then with "DEL" OP)

Configuration

[
        {
                "DASH_APPLIANCE_TABLE:123" : {
                        "sip":"10.1.0.32",
                        "vm_vni":"4321"
                },
                "OP": "DEL"
        },
        {
                "DASH_VNET_TABLE:Vnet1" : {
                        "vni":"1000",
                        "guid":"559c6ce8-26ab-4193-b946-ccc6e8f930b2"
                },
                "OP": "DEL"
        },
        {
                "DASH_VNET_TABLE:Vnet2" : {
                        "vni":"2000",
                        "guid":"659c6ce8-26ab-4193-b946-ccc6e8f930b2"
                },
                "OP": "DEL"
        },
        {
                "DASH_VNET_MAPPING_TABLE:Vnet2:20.2.2.2" : {
                        "routing_type":"vnet_encap",
                        "underlay_ip":"10.0.2.2",
                        "mac_address":"F9:22:83:99:22:A2",
                        "use_dst_vni":"true"
                },
                "OP": "DEL"
        },
        {
                "DASH_QOS_TABLE:qos100" : {
                        "qos_id":"100",
                        "bw":"10000",
                        "cps":"1000",
                        "flows":"10"
                },
                "OP": "DEL"
        },
        {
                "DASH_ENI_TABLE:F4939FEFC47E" : {
                        "eni_id":"497f23d7-f0ac-4c99-a98f-59b470e8c7bd",
                        "mac_address":"F4:93:9F:EF:C4:7E",
                        "underlay_ip":"10.0.1.2",
                        "admin_state":"enabled",
                        "vnet":"Vnet1",
                        "qos":"qos100"
                },
                "OP": "DEL"
        },
        {
                "DASH_ROUTE_TABLE:F4939FEFC47E:20.2.2.0/24" : {
                        "action_type":"vnet",
                        "vnet":"Vnet2"
                },
                "OP": "DEL"
        },        
		{
                "DASH_ROUTE_RULE_TABLE:F4939FEFC47E:2000:10.0.2.0/24" : {
                        "action_type":"decap",
                        "priority":"1",
                        "pa_validation":"true",
                        "vnet":"Vnet2"
                },
                "OP": "DEL"
        }
]

The reason is that routes reference ENI, so deleting the ENI before the routes produce errors in the meta validation. After the routes are deleted, ENI is also deleted successfully.

[liat-grozovik]

@prabhataravind is there an ETA to handle this one?

[prabhataravind]

Setting ETA to 09/22 but will try to get it in earlier.

[oleksandrivantsiv]

@prabhataravind kindly reminder. Do we have a new ETA for the issue?