sonic-swss
sonic-swss copied to clipboard
sonic-net
[Mclagsyncd] Ignore select event if its return value is error.
What I did Ignore select event if its return value is error.
Why I did it In order to prevent the mclagsyncd terminated.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: Minkang-Tsai (489fc92cb5fcf5a417b4efe959c4e59aa4c10ae0)
- :white_check_mark: login: prsunny / name: Prince Sunny (78707dda2300d930631ed570f37075769d16e81a)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Minkang-Tsai , I have a few asks for you: 1, Is there an issue filed for this issue that you are trying to fix? If so, can you link it to this PR? 2. Can you add Unit test testcase for this change. I don't see any test code added/changed to cover your changes.
@Praveen-Brcm can you please help review this? Thanks!
@Minkang-Tsai , I have a few asks for you: 1, Is there an issue filed for this issue that you are trying to fix? If so, can you link it to this PR? 2. Can you add Unit test testcase for this change. I don't see any test code added/changed to cover your changes.
@Praveen-Brcm can you please help review this? Thanks!
Hi @gechiang We try to kill docker database directly. Under this situation, select return value in mclagsyncd is ERROR, but it can continue to do the following steps to possibly cause the segment fault. Do you think that we need to create a PR to record that issue?
@Minkang-Tsai , I have a few asks for you: 1, Is there an issue filed for this issue that you are trying to fix? If so, can you link it to this PR? 2. Can you add Unit test testcase for this change. I don't see any test code added/changed to cover your changes. @Praveen-Brcm can you please help review this? Thanks!
Hi @gechiang Our customer try to kill docker database directly. Under this situation, select return value in mclagsyncd is ERROR, but it can continue to do the following steps to possibly cause the segment fault. Do you think that we need to create a PR to record that issue?
You have two choices:
- Raise a GIT hub issue under sonic-net/sonic-buildimage for what your customer tried and describes the steps, and what was observed, and what is the desired outcome after the trigger was made. and share the issue link in this PR.
- Fully describe the issue as I described above without filing a git hub issue in this PR description section.
Reason for this ask is we need to clearly describe the scenario involved so it helps the reviewer to see what is happening and what your changes will help to resolve the issue.