sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

[bufferorch] : Support for buffer profiles for VoQ on chassis

Open vmittal-msft opened this issue 3 years ago • 2 comments

What I did Added support for applying QoS profiles on VoQ on chassis

Why I did it egress_lossy_profile/egress_lossless_profiles were not applied on remote ports on the DUT and were only available for local ports.

How I verified it Verified that buffer profiles are applied properly on lossy/lossless VoQs on real HW.

Details if related This PR is dependent on -

https://github.com/sonic-net/sonic-swss/pull/1913 https://github.com/sonic-net/sonic-buildimage/pull/12156 https://github.com/sonic-net/sonic-swss/pull/2467

vmittal-msft avatar Sep 20 '22 18:09 vmittal-msft

/azp run

vmittal-msft avatar Oct 07 '22 04:10 vmittal-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 07 '22 04:10 azure-pipelines[bot]

This pull request introduces 1 alert and fixes 1 when merging b9edabe155d039eef74c8ed332601e567181af25 into dbdf31c10958414ee108850e8ee244c90d28b544 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused local variable

lgtm-com[bot] avatar Oct 25 '22 22:10 lgtm-com[bot]

/azp run

vmittal-msft avatar Dec 02 '22 23:12 vmittal-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 02 '22 23:12 azure-pipelines[bot]

/azp run

vmittal-msft avatar Dec 07 '22 16:12 vmittal-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 07 '22 16:12 azure-pipelines[bot]

This pull request fixes 1 alert when merging a0f0f30b0296a9fb181946936e16519b27883c7d into b8521cc6633155cabb570f15c10c79a93acf3f59 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Dec 07 '22 22:12 lgtm-com[bot]

This pull request fixes 1 alert when merging 60b2d10ea5f792826e069ed2ee6931f601fd62ab into 872f7bf9f3cf14112efc58005c9f5acfc520e894 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Dec 08 '22 05:12 lgtm-com[bot]

This pull request fixes 2 alerts when merging 3296bdde5a715b1078a412d79d4ed18c106c6b3e into 669511341e84564aa5f1c4c7bb757cc5709fd638 - view on LGTM.com

fixed alerts:

  • 2 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Dec 08 '22 08:12 lgtm-com[bot]

/azp run

vmittal-msft avatar Dec 09 '22 18:12 vmittal-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 09 '22 18:12 azure-pipelines[bot]

/azp run

vmittal-msft avatar Dec 10 '22 00:12 vmittal-msft

Commenter does not have sufficient privileges for PR 2465 in repo sonic-net/sonic-swss

azure-pipelines[bot] avatar Dec 10 '22 00:12 azure-pipelines[bot]

/azp run

prsunny avatar Dec 16 '22 18:12 prsunny

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 16 '22 18:12 azure-pipelines[bot]

/azp run

prsunny avatar Dec 19 '22 18:12 prsunny

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 19 '22 18:12 azure-pipelines[bot]

/azp run

vmittal-msft avatar Dec 20 '22 14:12 vmittal-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 20 '22 14:12 azure-pipelines[bot]

@vmittal-msft cherry-picking this PR to 202205 branch causes build failure, please raise separate PR.

Failure message: portsorch.cpp:7795:12: note: suggested alternative: 'gbport_stat_ids'return m_port_voq_ids[port.m_alias];^~~~~~~~~~~~~~gbport_stat_ids

yxieca avatar Jan 05 '23 00:01 yxieca