sonic-swss
sonic-swss copied to clipboard
Enhance orchagent and buffer manager in error handling
What I did Enhance orchagent and buffer manager
- Buffer manager: do not insert buffer queue into cache if the profile is illegal, which prevents an empty string from being inserted into
APPL_DB
during initialization. - orchagent: handle the case that a field referencing other objects is an empty string. There had been such logic that was broken by a PR last year.
Signed-off-by: Stephen Sun [email protected]
Why I did it
Enhance the error handling logic.
In most cases, a user will not encounter such scenarios in a production environment because it's the front-ends' (eg. CLI) responsibility to identify the wrong configuration and prevent them from being inserted to CONFIG_DB
.
However, in some cases, like a wrong config_db.json
composed and copied to the switch, front-ends can not prevent that.
How I verified it Manual and mock tests.
Details if related
/azpw run
/AzurePipelines run
Azure Pipelines successfully started running 1 pipeline(s).
/azpw run
/AzurePipelines run
Azure Pipelines successfully started running 1 pipeline(s).
@neethajohn , @prsunny kindly reminder as this is a bug fixc for 202205 appreciate if you can prioritize it.
@neethajohn , can you please review/sign-off?