sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

Enhance orchagent and buffer manager in error handling

Open stephenxs opened this issue 2 years ago • 6 comments

What I did Enhance orchagent and buffer manager

  • Buffer manager: do not insert buffer queue into cache if the profile is illegal, which prevents an empty string from being inserted into APPL_DB during initialization.
  • orchagent: handle the case that a field referencing other objects is an empty string. There had been such logic that was broken by a PR last year.

Signed-off-by: Stephen Sun [email protected]

Why I did it Enhance the error handling logic. In most cases, a user will not encounter such scenarios in a production environment because it's the front-ends' (eg. CLI) responsibility to identify the wrong configuration and prevent them from being inserted to CONFIG_DB. However, in some cases, like a wrong config_db.json composed and copied to the switch, front-ends can not prevent that.

How I verified it Manual and mock tests.

Details if related

stephenxs avatar Aug 15 '22 12:08 stephenxs

/azpw run

stephenxs avatar Aug 16 '22 02:08 stephenxs

/AzurePipelines run

mssonicbld avatar Aug 16 '22 02:08 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 16 '22 02:08 azure-pipelines[bot]

/azpw run

stephenxs avatar Aug 16 '22 12:08 stephenxs

/AzurePipelines run

mssonicbld avatar Aug 16 '22 12:08 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 16 '22 12:08 azure-pipelines[bot]

@neethajohn , @prsunny kindly reminder as this is a bug fixc for 202205 appreciate if you can prioritize it.

liat-grozovik avatar Sep 07 '22 11:09 liat-grozovik

@neethajohn , can you please review/sign-off?

prsunny avatar Sep 09 '22 03:09 prsunny