sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

[202111] [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected

Open vivekrnv opened this issue 2 years ago • 15 comments

What I did Avoid dropping traffic that is ingressing the port/pg that is in storm. The code changes in this PR avoid creating the ingress zero pool and profile and does not attach any zero profile to the ingress pg when pfcwd is triggered

Revert changes related to #1480 where the retry mechanism was added to BufferOrch which caches the task retries and while the PG is locked by PfcWdZeroBufferHandler.

Revert changes related to #2164 in PfcWdZeroBufferHandler & ZeroBufferProfile & BufferOrch.

Updated UT's accordingly

Signed-off-by: Vivek Reddy Karri [email protected]

What I did

Why I did it

How I verified it

Details if related

vivekrnv avatar Aug 01 '22 22:08 vivekrnv

/azpw run Azure.sonic-swss

vivekrnv avatar Aug 01 '22 23:08 vivekrnv

/AzurePipelines run Azure.sonic-swss

mssonicbld avatar Aug 01 '22 23:08 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 01 '22 23:08 azure-pipelines[bot]

@neethajohn Please signoff.

dgsudharsan avatar Aug 01 '22 23:08 dgsudharsan

/azpw run Azure.sonic-swss

vivekrnv avatar Aug 03 '22 20:08 vivekrnv

/AzurePipelines run Azure.sonic-swss

mssonicbld avatar Aug 03 '22 20:08 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 03 '22 20:08 azure-pipelines[bot]

/azp run Azure.sonic-swss

liat-grozovik avatar Aug 08 '22 12:08 liat-grozovik

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 08 '22 12:08 azure-pipelines[bot]

/azpw run Azure.sonic-swss

vivekrnv avatar Aug 08 '22 20:08 vivekrnv

/AzurePipelines run Azure.sonic-swss

mssonicbld avatar Aug 08 '22 20:08 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 08 '22 20:08 azure-pipelines[bot]

/azpw run Azure.sonic-swss

vivekrnv avatar Aug 12 '22 18:08 vivekrnv

/AzurePipelines run Azure.sonic-swss

mssonicbld avatar Aug 12 '22 18:08 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 12 '22 18:08 azure-pipelines[bot]

/azpw run Azure.sonic-swss

vivekrnv avatar Aug 22 '22 22:08 vivekrnv

/AzurePipelines run Azure.sonic-swss

mssonicbld avatar Aug 22 '22 22:08 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 22 '22 22:08 azure-pipelines[bot]

/azp run Azure.sonic-swss

liat-grozovik avatar Aug 29 '22 13:08 liat-grozovik

/easycla

liat-grozovik avatar Aug 29 '22 13:08 liat-grozovik

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 29 '22 13:08 azure-pipelines[bot]

/azpw run Azure.sonic-swss

judyjoseph avatar Sep 28 '22 17:09 judyjoseph

/azpw run Azure.sonic-swss

vivekrnv avatar Sep 28 '22 17:09 vivekrnv

/AzurePipelines run Azure.sonic-swss

mssonicbld avatar Sep 28 '22 17:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 28 '22 17:09 azure-pipelines[bot]

/azpw run Azure.sonic-swss

@judyjoseph Looks like the build job (Azure.sonic-swss (Build amd64)) is itself failing now

vivekrnv avatar Sep 28 '22 18:09 vivekrnv

Closing this PR. A label is added to https://github.com/sonic-net/sonic-swss/pull/2304 which is cherry-pickable.

dgsudharsan avatar Oct 12 '22 16:10 dgsudharsan