sonic-swss
sonic-swss copied to clipboard
sonic-net
Revert "Add support for IP interface loopback action (#2307)"
This reverts commit 5043701cc87efc3cb642762b13217729b576cf59.
Revert "[VS Test] Skip failing subport tests (#2370)"
This reverts commit 71752450e5d2c3c2f126aabddfe65b1d14344490.
What I did
Why I did it
How I verified it
Details if related
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@liorghub , We just re-added the subport test in this PR - https://github.com/Azure/sonic-swss/pull/2389 and it failed. So somehow it is linked to the changes. Can you please investigate this with priority?
@liorghub , We just re-added the subport test in this PR - #2389 and it failed. So somehow it is linked to the changes. Can you please investigate this with priority?
@prsunny @dprital I tried to reproduce the issue that occured in vstest of PR https://github.com/Azure/sonic-swss/pull/2389 but unfortunately I couldn't. In my run there were other failures. vstest in PR https://github.com/Azure/sonic-swss/pull/2389 failed since there were 2 keys in table ASIC_STATE:SAI_OBJECT_TYPE_VIRTUAL_ROUTER. I searched the code to understand what is the flow that creates a new key and found that it happens once on switch init and each time we create VRF or EVPN tunnel. My tests are not creating VRF or tunnel, therefore they could not cause the failure. If you still think otherwise, appreciate if we can work together to resolve the issue before reverting my commit (https://github.com/Azure/sonic-swss/commit/5043701cc87efc3cb642762b13217729b576cf59)
@liorghub , We just re-added the subport test in this PR - #2389 and it failed. So somehow it is linked to the changes. Can you please investigate this with priority?
@prsunny @dprital I tried to reproduce the issue that occured in vstest of PR #2389 but unfortunately I couldn't. In my run there were other failures. vstest in PR #2389 failed since there were 2 keys in table ASIC_STATE:SAI_OBJECT_TYPE_VIRTUAL_ROUTER. I searched the code to understand what is the flow that creates a new key and found that it happens once on switch init and each time we create VRF or EVPN tunnel. My tests are not creating VRF or tunnel, therefore they could not cause the failure. If you still think otherwise, appreciate if we can work together to resolve the issue before reverting my commit (5043701)
We are also not clear on the rootcause, but reverting your PR makes it pass, but with the changes, its failing. If you cannot repro it manually, can you try by reverting the changes one-by-one. Like remove intfmgrd but keep intforch and raise a PR. Lets try to narrow down.